* bug#20067: [PATCH] system: grub: Introduce foreign-menu-entry.
[not found] <20160803064249.7433-1-sleep_walker@gnu.org>
@ 2016-08-03 16:52 ` Ludovic Courtès
[not found] ` <87lh0d23sf.fsf@gnu.org>
1 sibling, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2016-08-03 16:52 UTC (permalink / raw)
To: Tomáš Čech; +Cc: guix-devel, 20067
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
Hi!
Tomáš Čech <sleep_walker@gnu.org> skribis:
> * gnu/system/grub(foreign-menu-entry): New record type.
>
> menu-entry type is suitable for kernel and initrd from GuixSD as it is looking
> for menu-entry-linux/bzImage for kernel in every case which makes pasing any
> other form impossible.
AIUI, this is a followup to <http://bugs.gnu.org/20067>, and it’s
admittedly a shame that this isn’t fixed!
I still think that the approach proposed at
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20067#10> is more
appropriate; ‘menu-entry’ would always work, no duplication would be
necessary.
As a stop-gap measure, I would prefer to (1) allow:
(menu-entry
;; …
(linux #~(string-append #$kernel "/bzImage")))
(2) remove the “/bzImage” assumption and use the above idiom everywhere
in the current code, and (3) and have a hack along these lines to
correctly interpret (string-append …) in the ‘parameters’ file:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 586 bytes --]
diff --git a/gnu/system.scm b/gnu/system.scm
index d6bf6c4..467d907 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -766,7 +766,11 @@ this file is the reconstruction of GRUB menu entries for old configurations."
(boot-parameters
(label label)
(root-device root)
- (kernel linux)
+ (kernel (match linux
+ (('string-append (? string? strings) ...)
+ (string-concatenate strings))
+ (_
+ linux)))
(kernel-arguments
(match (assq 'kernel-arguments rest)
((_ args) args)
[-- Attachment #3: Type: text/plain, Size: 34 bytes --]
Thoughts?
Thanks,
Ludo’.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#20067: [PATCH] system: grub: Introduce foreign-menu-entry.
[not found] ` <87lh0d23sf.fsf@gnu.org>
@ 2016-08-04 5:38 ` Chris Marusich
0 siblings, 0 replies; 2+ messages in thread
From: Chris Marusich @ 2016-08-04 5:38 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel, 20067
[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]
ludo@gnu.org (Ludovic Courtès) writes:
> I still think that the approach proposed at
> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20067#10> is more
> appropriate; ‘menu-entry’ would always work, no duplication would be
> necessary.
>
> As a stop-gap measure, I would prefer to (1) allow:
>
> (menu-entry
> ;; …
> (linux #~(string-append #$kernel "/bzImage")))
>
> (2) remove the “/bzImage” assumption and use the above idiom everywhere
> in the current code, and (3) and have a hack along these lines to
> correctly interpret (string-append …) in the ‘parameters’ file:
>
>
> diff --git a/gnu/system.scm b/gnu/system.scm
> index d6bf6c4..467d907 100644
> --- a/gnu/system.scm
> +++ b/gnu/system.scm
> @@ -766,7 +766,11 @@ this file is the reconstruction of GRUB menu entries for old configurations."
> (boot-parameters
> (label label)
> (root-device root)
> - (kernel linux)
> + (kernel (match linux
> + (('string-append (? string? strings) ...)
> + (string-concatenate strings))
> + (_
> + linux)))
> (kernel-arguments
> (match (assq 'kernel-arguments rest)
> ((_ args) args)
>
>
> Thoughts?
Yes, that approach seems better to me.
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-04 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20160803064249.7433-1-sleep_walker@gnu.org>
2016-08-03 16:52 ` bug#20067: [PATCH] system: grub: Introduce foreign-menu-entry Ludovic Courtès
[not found] ` <87lh0d23sf.fsf@gnu.org>
2016-08-04 5:38 ` Chris Marusich
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).