* bug#38445: Guix CI evaluation broken
@ 2019-12-01 17:20 Clément Lassieur
2019-12-02 3:33 ` Bengt Richter
0 siblings, 1 reply; 6+ messages in thread
From: Clément Lassieur @ 2019-12-01 17:20 UTC (permalink / raw)
To: 38445, ludo
Hi,
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5
broke Guix CI.
The reason is:
(local-file (string-append "" "../some-file"))
now differs from
(local-file "../some-file")
And in gnu/system/install.scm (line 246) there's a STRING-APPEND.
We could probably do an easy fix by changing (string-append
"exemples/" ...) to (string-append "gnu/system/exemples/" ...) but
still, I find that new behaviour weird.
Clément
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#38445: Guix CI evaluation broken 2019-12-01 17:20 bug#38445: Guix CI evaluation broken Clément Lassieur @ 2019-12-02 3:33 ` Bengt Richter 2019-12-02 9:04 ` Clément Lassieur 2019-12-02 9:24 ` Ludovic Courtès 0 siblings, 2 replies; 6+ messages in thread From: Bengt Richter @ 2019-12-02 3:33 UTC (permalink / raw) To: Clément Lassieur; +Cc: 38445 On +2019-12-01 18:20:24 +0100, Clément Lassieur wrote: > Hi, > > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5 > > broke Guix CI. > > The reason is: > > (local-file (string-append "" "../some-file")) > > now differs from > > (local-file "../some-file") > > And in gnu/system/install.scm (line 246) there's a STRING-APPEND. > > We could probably do an easy fix by changing (string-append ┌──────────────────────────────────────────────────────────────────────┐ │ Would s/exemples/examples/g do any good? │ ├──────────────────────────────────────────────────────────────────────┤ │ > "exemples/" ...) to (string-append "gnu/system/exemples/" ...) but │ │ > still, I find that new behaviour weird. │ └──────────────────────────────────────────────────────────────────────┘ > > Clément > > > -- Regards, Bengt Richter ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#38445: Guix CI evaluation broken 2019-12-02 3:33 ` Bengt Richter @ 2019-12-02 9:04 ` Clément Lassieur 2019-12-02 9:24 ` Ludovic Courtès 1 sibling, 0 replies; 6+ messages in thread From: Clément Lassieur @ 2019-12-02 9:04 UTC (permalink / raw) To: Bengt Richter; +Cc: 38445 Bengt Richter <bokr@bokr.com> writes: > Would s/exemples/examples/g do any good? Definitely. ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#38445: Guix CI evaluation broken 2019-12-02 3:33 ` Bengt Richter 2019-12-02 9:04 ` Clément Lassieur @ 2019-12-02 9:24 ` Ludovic Courtès 2019-12-02 9:33 ` Clément Lassieur [not found] ` <8736e3138y.fsf@lassieur.org> 1 sibling, 2 replies; 6+ messages in thread From: Ludovic Courtès @ 2019-12-02 9:24 UTC (permalink / raw) To: Bengt Richter; +Cc: 38445-done, Clément Lassieur Hi Clément & Bengt, Bengt Richter <bokr@bokr.com> skribis: > On +2019-12-01 18:20:24 +0100, Clément Lassieur wrote: >> Hi, >> >> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5 >> >> broke Guix CI. >> >> The reason is: >> >> (local-file (string-append "" "../some-file")) >> >> now differs from >> >> (local-file "../some-file") >> >> And in gnu/system/install.scm (line 246) there's a STRING-APPEND. >> >> We could probably do an easy fix by changing (string-append Sorry for the breakage! I noticed it yesterday and fixed it in 33d1c970c323971da8d70a662748c7b1b520d6b6. Let me know if you think anything else is wrong! Thanks, Ludo’. ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#38445: Guix CI evaluation broken 2019-12-02 9:24 ` Ludovic Courtès @ 2019-12-02 9:33 ` Clément Lassieur [not found] ` <8736e3138y.fsf@lassieur.org> 1 sibling, 0 replies; 6+ messages in thread From: Clément Lassieur @ 2019-12-02 9:33 UTC (permalink / raw) To: Ludovic Courtès, guix-devel; +Cc: 38445-done Hi Ludo, Ludovic Courtès <ludo@gnu.org> writes: > Sorry for the breakage! I noticed it yesterday and fixed it in > 33d1c970c323971da8d70a662748c7b1b520d6b6. > > Let me know if you think anything else is wrong! I find the initial commit[1] counterintuitive and would have loved a discussion before the fix. I defy anyone to understand why commit 33d1c97[2] would fix anything. Adding guix-devel. Clément [1]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5 [2]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=33d1c970c323971da8d70a662748c7b1b520d6b6 ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <8736e3138y.fsf@lassieur.org>]
* bug#38445: Guix CI evaluation broken [not found] ` <8736e3138y.fsf@lassieur.org> @ 2019-12-02 9:59 ` Clément Lassieur 0 siblings, 0 replies; 6+ messages in thread From: Clément Lassieur @ 2019-12-02 9:59 UTC (permalink / raw) To: Ludovic Courtès, guix-devel; +Cc: 38445-done Sorry for my tone, it might sound harsh, it's not what I meant, I just didn't have coffee yet ;) Clément Lassieur <clement@lassieur.org> writes: > Hi Ludo, > > Ludovic Courtès <ludo@gnu.org> writes: > >> Sorry for the breakage! I noticed it yesterday and fixed it in >> 33d1c970c323971da8d70a662748c7b1b520d6b6. >> >> Let me know if you think anything else is wrong! > > I find the initial commit[1] counterintuitive and would have loved a > discussion before the fix. > > I defy anyone to understand why commit 33d1c97[2] would fix anything. > > Adding guix-devel. > > Clément > > [1]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5 > [2]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=33d1c970c323971da8d70a662748c7b1b520d6b6 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-02 10:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-01 17:20 bug#38445: Guix CI evaluation broken Clément Lassieur
2019-12-02 3:33 ` Bengt Richter
2019-12-02 9:04 ` Clément Lassieur
2019-12-02 9:24 ` Ludovic Courtès
2019-12-02 9:33 ` Clément Lassieur
[not found] ` <8736e3138y.fsf@lassieur.org>
2019-12-02 9:59 ` Clément Lassieur
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).