unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#63371: [bug#63534] [PATCH] gnu: openboard: Update to 1.7-dev-0.47a96e1
       [not found] <87lehok7e8.fsf@xelera.eu>
@ 2023-05-25 11:03 ` Nicolas Goaziou
  0 siblings, 0 replies; only message in thread
From: Nicolas Goaziou @ 2023-05-25 11:03 UTC (permalink / raw)
  To: Giovanni Biscuolo; +Cc: 63534, 63371

Hello,

Giovanni Biscuolo <g@xelera.eu> writes:

> From c0405d2762eb173fb7357de700f1aefc606682f6 Mon Sep 17 00:00:00 2001
> Message-Id: <c0405d2762eb173fb7357de700f1aefc606682f6.1684218578.git.g@xelera.eu>
> From: Giovanni Biscuolo <g@xelera.eu>
> Date: Tue, 16 May 2023 08:08:56 +0200
> Subject: [PATCH] gnu: openboard: Update to 1.7-dev-0.47a96e1
>
> * gnu/packages/education.scm (openboard)[version]: Update to
> 1.7-dev-0.47a96e1

Nitpick: missing full stops at the end of sentences.

> [arguments]: Fix quazip and poppler library path


[...]

>                  (substitute* "OpenBoard.pro"
> -                  (("/usr/include/quazip")
> -                   (search-input-directory inputs "/include/quazip5"))
> +                  (("/usr/include/quazip5")
> +                   (search-input-directory inputs "include/quazip5"))
>                    (("/usr/include/poppler")
> -                   (search-input-directory inputs "/include/poppler")))))
> +                   (search-input-directory inputs "include/poppler")))))

I don't think these changes are warranted. Do they fix something?

Otherwise LGTM.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-05-25 11:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <87lehok7e8.fsf@xelera.eu>
2023-05-25 11:03 ` bug#63371: [bug#63534] [PATCH] gnu: openboard: Update to 1.7-dev-0.47a96e1 Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).