bug#37735: Ansible package build/installation failing

bug#37735: Ansible package build/installation failing

[Jonathan Frederickson]

[-- Attachment #1.1.1: Type: text/plain, Size: 1884 bytes --]

I recently tried to upgrade the packages on my desktop that are
installed through Guix, and Ansible is failing to build. (I've attached
the build log to this report.) I went looking for the cause, and it
looks like... the 'wrap' phase is failing because there's no 'sbin' path
in the store dir. I tried to fix that by accounting for that case in the
Python build system: https://issues.guix.gnu.org/issue/37722

However, even after that, the 'fix-symlinks' phase (defined in the
ansible package itself) is failing:

starting phase `fix-symlinks'
Backtrace:
           8 (primitive-load "/gnu/store/x87ddva1qdjfa68sh0a74s3i6gn…")
In ice-9/eval.scm:
   191:35  7 (_ _)
In ice-9/boot-9.scm:
    829:9  6 (catch _ _ #<procedure 7ffff5bac518 at /gnu/store/qxai…> …)
In srfi/srfi-1.scm:
   863:16  5 (every1 #<procedure 7ffff4d1b120 at /gnu/store/qxai6lh…> …)
In
/gnu/store/qxai6lhbg2c4q37s5qf3cddwl0q61ng2-module-import/guix/build/gnu-build-system.scm:
   839:30  4 (_ _)
In ice-9/eval.scm:
    619:8  3 (_ #(#(#<directory (guile-user) 7ffff5c70140>) ((. #))))
In ice-9/boot-9.scm:
   260:13  2 (for-each #<procedure 7ffff4d23540 at ice-9/eval.scm:3…> …)
In ice-9/eval.scm:
    619:8  1 (_ #(#(#<directory (guile-user) 7ffff5c70140> "/gn…") #))
In unknown file:
           0 (delete-file "/gnu/store/8w285skr915h0i5yg0ky1klj1lzy7j…")

ERROR: In procedure delete-file:
In procedure delete-file: No such file or directory

This leads me to believe that the problem may have been introduced
somewhere else and that there *should* be an 'sbin' dir in that store
dir. (Although I can't see the full path in that backtrace as the string
is truncated.)

I'll keep digging, but I figured I'd post here in case anyone with
deeper knowledge of the build flow has a better idea of what's wrong.


[-- Attachment #1.1.2: xa0h9238fsx0ar16i8fx2h8nyki7v0-ansible-2.8.1.drv.bz2 --]
[-- Type: application/x-bzip, Size: 178426 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#37735: Acknowledgement (Ansible package build/installation failing)

[Jonathan Frederickson]

[-- Attachment #1.1: Type: text/plain, Size: 1678 bytes --]

Aha, I managed to expand that backtrace a bit. The failure here isn't
quite what I was expecting:

starting phase `fix-symlinks'
Backtrace:
           8 (primitive-load
"/gnu/store/4sx0bpv580768j5i6g47gcfkb8kp2c12-ansible-2.8.1-guile-builder")
In ice-9/eval.scm:
   191:35  7 (_ _)
In ice-9/boot-9.scm:
    829:9  6 (catch _ _ #<procedure 7ffff5bac518 at
/gnu/store/qxai6lhbg2c4q37s5qf3cddwl0q61ng2-module-import/guix/build/gnu-build-system.scm:830:2
(key c)> _)
In srfi/srfi-1.scm:
   863:16  5 (every1 #<procedure 7ffff4d209e0 at
/gnu/store/qxai6lhbg2c4q37s5qf3cddwl0q61ng2-module-import/guix/build/gnu-build-system.scm:835:11
(expr)> ((fix-symlinks . #<procedure 7ffff4d0b3c0 at
ice-9/eval.scm:457:6 args>) (check . #<procedure check (#:key tests?
test-target use-setuptoo…>) …))
In
/gnu/store/qxai6lhbg2c4q37s5qf3cddwl0q61ng2-module-import/guix/build/gnu-build-system.scm:
   839:30  4 (_ _)
In ice-9/eval.scm:
    619:8  3 (_ #(#(#<directory (guile-user) 7ffff5c70140>) (("out" .
"/gnu/store/y36h6a36690lq6zvc3q3cf35ylmd95kr-ansible-2.8.1"))))
In ice-9/boot-9.scm:
   260:13  2 (for-each #<procedure 7fffefdb9620 at ice-9/eval.scm:333:13
(a)> ("config" "console" "doc" "galaxy" "inventory" "playbook" "pull"
"vault"))
In ice-9/eval.scm:
    619:8  1 (_ #(#(#<directory (guile-user) 7ffff5c70140>
"/gnu/store/y36h6a36690lq6zvc3q3cf35ylmd95kr-ansible-2.8.1") "config"))
In unknown file:
           0 (delete-file
"/gnu/store/y36h6a36690lq6zvc3q3cf35ylmd95kr-ansible-2.8.1/bin/.ansible-config-real")

ERROR: In procedure delete-file:
In procedure delete-file: No such file or directory



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#37735: Ansible package build/installation failing

[Arun Isaac]

[-- Attachment #1.1: Type: text/plain, Size: 116 bytes --]


Hi,

I have a patch fixing the build. Please find attached. Could you confirm
that it works as expected?

Thanks.


[-- Attachment #1.2: 0001-gnu-ansible-Work-around-issues-with-Guix-wrapper-scr.patch --]
[-- Type: text/x-patch, Size: 2810 bytes --]

From 0f643e80815190cd8fc800f6a3f8e813992e70cb Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Tue, 15 Oct 2019 01:53:06 +0530
Subject: [PATCH] gnu: ansible: Work around issues with Guix wrapper scripts.

* gnu/packages/admin.scm (ansible)[arguments]: Remove fix-symlinks phase. Add
replace-symlinks phase.
---
 gnu/packages/admin.scm | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 35dae2d056..0e4fb3947c 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -19,7 +19,7 @@
 ;;; Copyright © 2017 Ethan R. Jones <doubleplusgood23@gmail.com>
 ;;; Copyright © 2017 Christopher Allan Webber <cwebber@dustycloud.org>
 ;;; Copyright © 2017, 2018 Marius Bakke <mbakke@fastmail.com>
-;;; Copyright © 2018 Arun Isaac <arunisaac@systemreboot.net>
+;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2018 Pierre-Antoine Rouby <pierre-antoine.rouby@inria.fr>
 ;;; Copyright © 2018 Rutger Helling <rhelling@mykolab.com>
 ;;; Copyright © 2018 Pierre Neidhardt <mail@ambrevar.xyz>
@@ -1880,21 +1880,16 @@ import re
 sys.argv[0] = re.sub(r'\\.([^/]*)-real$', r'\\1', sys.argv[0])
 ")))
              #t))
-         (add-after 'wrap 'fix-symlinks
+         (add-after 'install 'replace-symlinks
            (lambda* (#:key outputs #:allow-other-keys)
+             ;; Replace symlinks with duplicate copies of the ansible
+             ;; executable.
              (let ((out (assoc-ref outputs "out")))
                (for-each
                 (lambda (subprogram)
-                  ;; The symlinks point to the ansible wrapper script. Make
-                  ;; them point to the real executable (.ansible-real).
-                  (delete-file (string-append out "/bin/.ansible-" subprogram "-real"))
-                  (symlink (string-append out "/bin/.ansible-real")
-                           (string-append out "/bin/.ansible-" subprogram "-real"))
-                  ;; The wrapper scripts of the symlinks invoke the ansible
-                  ;; wrapper script. Fix them to invoke the correct executable.
-                  (substitute* (string-append out "/bin/ansible-" subprogram)
-                    (("/bin/ansible")
-                     (string-append "/bin/.ansible-" subprogram "-real"))))
+                  (delete-file (string-append out "/bin/ansible-" subprogram))
+                  (copy-file (string-append out "/bin/ansible")
+                             (string-append out "/bin/ansible-" subprogram)))
                 (list "config" "console" "doc" "galaxy"
                       "inventory" "playbook" "pull" "vault")))
              #t)))))
-- 
2.23.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#37735: Ansible package build/installation failing

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]


I felt pretty sure about this patch. So, I pushed it to
master. Meanwhile, I also updated ansible to the latest 2.8.5. I am
closing this bug report now. Please feel free to open a new bug report
in case there are any further problems.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]