unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Reza Alizadeh Majd" <r.majd@pantherx.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 38926@debbugs.gnu.org
Subject: bug#38926: pcmanfm-qt unable to open files by double click
Date: Sun, 05 Jan 2020 17:22:42 +0330	[thread overview]
Message-ID: <2e3e1ced-2c3c-4084-817d-ac19aca5562d@www.fastmail.com> (raw)
In-Reply-To: <20200105105655.5dde2d6c@scratchpost.org>

Hi,

> Unfortunately, that way is not acceptable.
> 
> Long story short, please make it a regular input.  The reasoning is below:
> 
> Guix has better modularity than most of the other distributions that exist.

OK, I got your point, so I think following patch could be acceptable now:

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 5a3708e30a..fdadb03dda 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -1000,7 +1000,17 @@ components to build desktop file managers which belongs to LXDE.")
              (substitute* '("autostart/CMakeLists.txt")
                (("DESTINATION \"\\$\\{LXQT_ETC_XDG_DIR\\}")
                 "DESTINATION \"etc/xdg"))
-             #t)))))
+             #t))
+         (add-after 'install 'wrap-executable
+           (lambda* (#:key outputs inputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (glib-bin (string-append (assoc-ref inputs "glib") "/bin")))
+               (display "[=] ")
+               (display glib-bin)
+               (newline)
+               (wrap-program (string-append out "/bin/pcmanfm-qt")
+                 `("PATH" ":" prefix (,glib-bin)))
+               #t))))))
     (home-page "https://lxqt.org/")
     (synopsis "File manager and desktop icon manager")
     (description "PCManFM-Qt is the Qt port of PCManFM, the file manager of
(END)
--8<---------------cut here---------------end--------------->8---

so please let me know, if any other issues are still exists. 

-- 
Regards
Reza Alizadeh Majd
PantherX Team

  reply	other threads:[~2020-01-05 13:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-04 20:24 bug#38926: pcmanfm-qt unable to open files by double click Reza Alizadeh Majd
2020-01-05  9:56 ` Danny Milosavljevic
2020-01-05 13:52   ` Reza Alizadeh Majd [this message]
2020-01-05 22:37     ` Danny Milosavljevic
2020-01-05 22:57       ` Danny Milosavljevic
2020-01-06 10:06         ` Danny Milosavljevic
2020-01-06 16:38         ` Danny Milosavljevic
2020-01-06 16:45           ` Reza Alizadeh Majd
2020-01-06 19:44             ` Danny Milosavljevic
2020-01-07  6:23               ` Reza Alizadeh Majd
2020-01-07  8:03                 ` Reza Alizadeh Majd
2020-01-07 11:19       ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e3e1ced-2c3c-4084-817d-ac19aca5562d@www.fastmail.com \
    --to=r.majd@pantherx.org \
    --cc=38926@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).