From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Reza Alizadeh Majd" Subject: bug#38926: pcmanfm-qt unable to open files by double click Date: Sun, 05 Jan 2020 17:22:42 +0330 Message-ID: <2e3e1ced-2c3c-4084-817d-ac19aca5562d@www.fastmail.com> References: <20200105105655.5dde2d6c@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:36509) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io6Lz-0001eT-6H for bug-guix@gnu.org; Sun, 05 Jan 2020 08:54:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1io6Lx-0002Yx-Vg for bug-guix@gnu.org; Sun, 05 Jan 2020 08:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1io6Lx-0002Xn-PJ for bug-guix@gnu.org; Sun, 05 Jan 2020 08:54:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1io6Lx-00066g-N9 for bug-guix@gnu.org; Sun, 05 Jan 2020 08:54:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20200105105655.5dde2d6c@scratchpost.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Danny Milosavljevic Cc: 38926@debbugs.gnu.org Hi, > Unfortunately, that way is not acceptable. > > Long story short, please make it a regular input. The reasoning is below: > > Guix has better modularity than most of the other distributions that exist. OK, I got your point, so I think following patch could be acceptable now: --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm index 5a3708e30a..fdadb03dda 100644 --- a/gnu/packages/lxqt.scm +++ b/gnu/packages/lxqt.scm @@ -1000,7 +1000,17 @@ components to build desktop file managers which belongs to LXDE.") (substitute* '("autostart/CMakeLists.txt") (("DESTINATION \"\\$\\{LXQT_ETC_XDG_DIR\\}") "DESTINATION \"etc/xdg")) - #t))))) + #t)) + (add-after 'install 'wrap-executable + (lambda* (#:key outputs inputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (glib-bin (string-append (assoc-ref inputs "glib") "/bin"))) + (display "[=] ") + (display glib-bin) + (newline) + (wrap-program (string-append out "/bin/pcmanfm-qt") + `("PATH" ":" prefix (,glib-bin))) + #t)))))) (home-page "https://lxqt.org/") (synopsis "File manager and desktop icon manager") (description "PCManFM-Qt is the Qt port of PCManFM, the file manager of (END) --8<---------------cut here---------------end--------------->8--- so please let me know, if any other issues are still exists. -- Regards Reza Alizadeh Majd PantherX Team