From: Sarah Morgensen <iskarian@mgsn.dev>
To: 50493@debbugs.gnu.org
Subject: bug#50493: [PATCH 4/4] build-system/go: Use go-1.17 by default.
Date: Sun, 19 Sep 2021 22:20:51 -0700 [thread overview]
Message-ID: <2db7749e36277825f029a3b059ca8d4daaa82cbc.1632099301.git.iskarian@mgsn.dev> (raw)
In-Reply-To: <cover.1632099301.git.iskarian@mgsn.dev>
Build all Go packages with go-1.17 by default. Explicitly specify an
older Go version in packages which cannot build with go-1.17.
* gnu/packages/golang.scm (go): Update from 'go-1.14' to 'go-1.17'.
* gnu/packages/docker.scm (docker)[native-inputs]: Explicitly use
'go-1.14'.
* gnu/packages/ipfs.scm (go-ipfs)[arguments]: Set #:go to 'go-1.16'.
(go-github-com-ipfs-go-ipfs-cmdkit-files)[arguments]: Likewise.
---
gnu/packages/docker.scm | 2 +-
gnu/packages/golang.scm | 2 +-
gnu/packages/ipfs.scm | 6 ++++--
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/docker.scm b/gnu/packages/docker.scm
index 8bac1b89ce..fa666cbb04 100644
--- a/gnu/packages/docker.scm
+++ b/gnu/packages/docker.scm
@@ -594,7 +594,7 @@ (define-public docker
("xz" ,xz)))
(native-inputs
`(("eudev" ,eudev) ; TODO: Should be propagated by lvm2 (.pc -> .pc)
- ("go" ,go)
+ ("go" ,go-1.14)
("gotestsum" ,gotestsum)
("pkg-config" ,pkg-config)))
(synopsis "Docker container component library, and daemon")
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 19f1ef37d5..d1ed30455c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -790,7 +790,7 @@ (define-public go-1.17
"README.md" "SECURITY.md"))))))))
(inputs (alist-delete "gcc:lib" (package-inputs go-1.16)))))
-(define-public go go-1.14)
+(define-public go go-1.17)
(define-public (make-go-std go)
"Return a package which builds the standard library for Go compiler GO."
diff --git a/gnu/packages/ipfs.scm b/gnu/packages/ipfs.scm
index 57701991e3..8d5b4f1767 100644
--- a/gnu/packages/ipfs.scm
+++ b/gnu/packages/ipfs.scm
@@ -46,7 +46,8 @@ (define-public go-github-com-ipfs-go-ipfs-cmdkit-files
"0qk6fshgdmhp8dip2ksm13j6nywi41m9mn0czkvmw6b697z85l2r"))))
(build-system go-build-system)
(arguments
- '(#:unpack-path "github.com/ipfs/go-ipfs-cmdkit"
+ `(#:go ,go-1.16
+ #:unpack-path "github.com/ipfs/go-ipfs-cmdkit"
#:import-path "github.com/ipfs/go-ipfs-cmdkit/files"))
(home-page "https://github.com/ipfs/go-ipfs-cmdkit")
(synopsis "Shared types, functions and values for go-ipfs")
@@ -226,7 +227,8 @@ (define-public go-ipfs
(file-name (string-append name "-" version "-source"))))
(build-system go-build-system)
(arguments
- '(#:unpack-path "github.com/ipfs/go-ipfs"
+ `(#:go ,go-1.16
+ #:unpack-path "github.com/ipfs/go-ipfs"
#:import-path "github.com/ipfs/go-ipfs/cmd/ipfs"
#:phases (modify-phases %standard-phases
(add-before 'reset-gzip-timestamps 'make-files-writable
--
2.33.0
prev parent reply other threads:[~2021-09-20 6:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 22:14 bug#50493: Update go-build-system to use Go 1.17 Sarah Morgensen
2021-09-09 22:37 ` Leo Famulari
2021-09-20 5:28 ` Sarah Morgensen
2021-12-14 20:11 ` Leo Famulari
2021-12-15 10:40 ` Efraim Flashner
2021-12-15 17:44 ` Leo Famulari
2021-12-15 18:03 ` Efraim Flashner
2021-12-17 22:09 ` Leo Famulari
2021-12-19 8:19 ` Efraim Flashner
2021-12-20 1:30 ` Leo Famulari
2021-12-20 2:31 ` Leo Famulari
2021-12-24 21:35 ` Leo Famulari
2021-09-20 5:19 ` bug#50493: [PATCH staging 0/4] build-system/go: Use go-1.17 by default Sarah Morgensen
2021-09-20 5:20 ` bug#50493: [PATCH 1/4] build-system/go: Add #:substitutable? argument Sarah Morgensen
2021-09-20 5:20 ` bug#50493: [PATCH 2/4] build-system/go: Initialize build cache from input packages Sarah Morgensen
2021-09-20 5:20 ` bug#50493: [PATCH 3/4] build-system/go: Add pre-built standard library as implicit input Sarah Morgensen
2021-09-20 5:20 ` Sarah Morgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2db7749e36277825f029a3b059ca8d4daaa82cbc.1632099301.git.iskarian@mgsn.dev \
--to=iskarian@mgsn.dev \
--cc=50493@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).