From: Leo Famulari <leo@famulari.name>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: 50493@debbugs.gnu.org
Subject: bug#50493: Update go-build-system to use Go 1.17.
Date: Thu, 9 Sep 2021 18:37:37 -0400 [thread overview]
Message-ID: <YTqMsUO8pzTgiifZ@jasmine.lan> (raw)
In-Reply-To: <865yv9mm5a.fsf@mgsn.dev>
On Thu, Sep 09, 2021 at 03:14:57PM -0700, Sarah Morgensen wrote:
> This is intended to be a tracking issue for updating go-build-system to
> use Go 1.17 by default. The build system currently uses Go 1.14, which
> no longer receives security updates [0].
Thanks for putting this together.
> Here's what needs to be done:
>
> 1. Address the aarch64 bug [1], either by verifying that it only happens
> on emulated systems, or by fixing it if not.
It looks like there was a patch for this issue:
https://github.com/golang/go/issues/20763#issuecomment-314627882
And it was apparently added to Go, but maybe it was not sufficient, did
not make it into a release, or we are seeing a different bug.
> 2. Make some much-needed improvements to go-build-system [2]:
>
> * replace the *slow* phase 'remove-go-references with -trimpath option
>
> * avoid building a directory union of Go inputs (and then copying it!)
Are these required to use 1.17? I agree they are important problems to
fix but we shouldn't let them block the upgrade.
> * add a "go-std-cache-for-build" package (hidden; name to be
> bikeshedded), which will be an implicit input in go-build-system (needed
> since we removed the pre-built standard library in go-1.17)
Okay. Feel free to choose the name. I think it's your shed.
> 3. Some/all Docker packages still require Go 1.14; make them use go-1.14
> explicitly. Alternatively, update Docker (significant effort involved).
Okay.
> 4. Update or patch broken packages. I've got patches for four so far:
>
> go-github-com-urfave-cli
> go-github-com-urfave-cli-v2
> go-github-com-sevlyar-go-daemon
> go-github-com-keybase-go-ps
>
> I'll submit them as a separate patch and block this with it. If anyone
> else would like to see if their favorite package works with Go 1.17, you
> can build it with:
Okay, great.
> go build --with-input=go@1.14=go@1.17 <package>
Syncthing builds! That's great.
next prev parent reply other threads:[~2021-09-09 22:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 22:14 bug#50493: Update go-build-system to use Go 1.17 Sarah Morgensen
2021-09-09 22:37 ` Leo Famulari [this message]
2021-09-20 5:28 ` Sarah Morgensen
2021-12-14 20:11 ` Leo Famulari
2021-12-15 10:40 ` Efraim Flashner
2021-12-15 17:44 ` Leo Famulari
2021-12-15 18:03 ` Efraim Flashner
2021-12-17 22:09 ` Leo Famulari
2021-12-19 8:19 ` Efraim Flashner
2021-12-20 1:30 ` Leo Famulari
2021-12-20 2:31 ` Leo Famulari
2021-12-24 21:35 ` Leo Famulari
2021-09-20 5:19 ` bug#50493: [PATCH staging 0/4] build-system/go: Use go-1.17 by default Sarah Morgensen
2021-09-20 5:20 ` bug#50493: [PATCH 1/4] build-system/go: Add #:substitutable? argument Sarah Morgensen
2021-09-20 5:20 ` bug#50493: [PATCH 2/4] build-system/go: Initialize build cache from input packages Sarah Morgensen
2021-09-20 5:20 ` bug#50493: [PATCH 3/4] build-system/go: Add pre-built standard library as implicit input Sarah Morgensen
2021-09-20 5:20 ` bug#50493: [PATCH 4/4] build-system/go: Use go-1.17 by default Sarah Morgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTqMsUO8pzTgiifZ@jasmine.lan \
--to=leo@famulari.name \
--cc=50493@debbugs.gnu.org \
--cc=iskarian@mgsn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).