* bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively
@ 2020-07-01 16:53 pkill9
2020-07-02 7:12 ` Efraim Flashner
2020-08-27 22:10 ` Jesse Gibbons
0 siblings, 2 replies; 6+ messages in thread
From: pkill9 @ 2020-07-01 16:53 UTC (permalink / raw)
To: 42155
For example, `guix build --with-source=youtube-dl=blahblah mpv` builds
mpv normally, after giving a message: guix build: warning:
transformation 'with-source' had no effect on mpv@0.32.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively
2020-07-01 16:53 bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively pkill9
@ 2020-07-02 7:12 ` Efraim Flashner
2020-07-02 17:44 ` pkill9
2020-08-27 22:10 ` Jesse Gibbons
1 sibling, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2020-07-02 7:12 UTC (permalink / raw)
To: pkill9; +Cc: 42155
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
On Wed, Jul 01, 2020 at 05:53:31PM +0100, pkill9 wrote:
> For example, `guix build --with-source=youtube-dl=blahblah mpv` builds
> mpv normally, after giving a message: guix build: warning:
> transformation 'with-source' had no effect on mpv@0.32.0
>
From 'guix build --help:'
--with-source=SOURCE
use SOURCE when building the corresponding package
--with-input=PACKAGE=REPLACEMENT
replace dependency PACKAGE by REPLACEMENT
I think what you're looking for is more of:
guix build --no-grafts mpv --with-input=youtube-dl=$(guix build --no-grafts youtube-dl --with-source=https://github.com/ytdl-org/youtube-dl/releases/download/2020.06.16/youtube-dl-2020.06.16.tar.gz)
This didn't work for me though, I got:
guix build: error: /gnu/store/9ncacjhzwlchpr1y5fd8ahdq59dsya20-youtube-dl-2020.06.16: unknown package
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively
2020-07-02 7:12 ` Efraim Flashner
@ 2020-07-02 17:44 ` pkill9
2020-07-02 21:59 ` Ludovic Courtès
0 siblings, 1 reply; 6+ messages in thread
From: pkill9 @ 2020-07-02 17:44 UTC (permalink / raw)
To: Efraim Flashner; +Cc: 42155
> I think what you're looking for is more of:
>
> guix build --no-grafts mpv --with-input=youtube-dl=$(guix build
> --no-grafts youtube-dl
> --with-source=https://github.com/ytdl-org/youtube-dl/releases/download/2020.06.16/youtube-dl-2020.06.16.tar.gz)
>
> This didn't work for me though, I got:
> guix build: error:
> /gnu/store/9ncacjhzwlchpr1y5fd8ahdq59dsya20-youtube-dl-2020.06.16:
> unknown package
Even if that worked, it doesn't fix the issue of the --with-source flag
not working on the specified package's inputs.
That command doesn't work because you're giving it a store path, not a
package specification.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively
2020-07-02 17:44 ` pkill9
@ 2020-07-02 21:59 ` Ludovic Courtès
2023-02-21 13:18 ` Maxim Cournoyer
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2020-07-02 21:59 UTC (permalink / raw)
To: pkill9; +Cc: 42155
pkill9 <pkill9@runbox.com> skribis:
>> I think what you're looking for is more of:
>>
>> guix build --no-grafts mpv --with-input=youtube-dl=$(guix build
>> --no-grafts youtube-dl
>> --with-source=https://github.com/ytdl-org/youtube-dl/releases/download/2020.06.16/youtube-dl-2020.06.16.tar.gz)
>>
>> This didn't work for me though, I got:
>> guix build: error:
>> /gnu/store/9ncacjhzwlchpr1y5fd8ahdq59dsya20-youtube-dl-2020.06.16:
>> unknown package
>
> Even if that worked, it doesn't fix the issue of the --with-source flag
> not working on the specified package's inputs.
‘--with-source’ is documented to be “shallow”: unlike ‘--with-input’ &
co., it doesn’t apply recursively.
I think we should change it though.
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively
2020-07-01 16:53 bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively pkill9
2020-07-02 7:12 ` Efraim Flashner
@ 2020-08-27 22:10 ` Jesse Gibbons
1 sibling, 0 replies; 6+ messages in thread
From: Jesse Gibbons @ 2020-08-27 22:10 UTC (permalink / raw)
To: 42155
(In response to issue at https://issues.guix.info/issue/42155):
I want to be able to specify dependency sources, so I am working on this
issue. It's complicated because --with-source= can take a simple source
(implying the package being built should be built from SOURCE) or
package=source (AIUI implying PACKAGE in the specified list of packages
should be built from SOURCE). Should we deprecate the current
interpretation of "--with-source=package=source"? Or would it be better
to preserve these options and make a new recursive
'--with-dependency-source=package=source' option?
I'm leaning towards making the option
"--with-dependency-source=package=source" because I think that will be
easier to accomplish and maintain. But if anyone has a compelling reason
to deprecate the old usage, I am willing to listen.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively
2020-07-02 21:59 ` Ludovic Courtès
@ 2023-02-21 13:18 ` Maxim Cournoyer
0 siblings, 0 replies; 6+ messages in thread
From: Maxim Cournoyer @ 2023-02-21 13:18 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: pkill9, 42155-done, Efraim Flashner
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> pkill9 <pkill9@runbox.com> skribis:
>
>>> I think what you're looking for is more of:
>>>
>>> guix build --no-grafts mpv --with-input=youtube-dl=$(guix build
>>> --no-grafts youtube-dl
>>> --with-source=https://github.com/ytdl-org/youtube-dl/releases/download/2020.06.16/youtube-dl-2020.06.16.tar.gz)
>>>
>>> This didn't work for me though, I got:
>>> guix build: error:
>>> /gnu/store/9ncacjhzwlchpr1y5fd8ahdq59dsya20-youtube-dl-2020.06.16:
>>> unknown package
>>
>> Even if that worked, it doesn't fix the issue of the --with-source flag
>> not working on the specified package's inputs.
>
> ‘--with-source’ is documented to be “shallow”: unlike ‘--with-input’ &
> co., it doesn’t apply recursively.
>
> I think we should change it though.
Closing, since that's been implemented per
28ade1bab207974cce6a014e7187968511fc5526 ("transformations:
'--with-source' now operates in depth.") last September.
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-21 13:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 16:53 bug#42155: --with-source=PACKAGE=REPLACEMENT-SOURCE doesn't work recursively pkill9
2020-07-02 7:12 ` Efraim Flashner
2020-07-02 17:44 ` pkill9
2020-07-02 21:59 ` Ludovic Courtès
2023-02-21 13:18 ` Maxim Cournoyer
2020-08-27 22:10 ` Jesse Gibbons
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).