unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 40528-done@debbugs.gnu.org
Subject: bug#40528: 'guix lint' does not check whether propagated-inputs should be native
Date: Fri, 10 Apr 2020 00:50:10 +0300	[thread overview]
Message-ID: <20200409215010.GY1518@E5400> (raw)
In-Reply-To: <87eeswjpz9.fsf@devup.no>

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote:
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote:
> >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
> >> a package, not propagated-inputs.
> >
> > The attached patch should add the propagated inputs to the list of
> > inputs to check. Do we want to start telling it to ignore some of them?
> 
> Wow, that was incredibly fast!
> 
> > gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose' should probably be a native input
> 
> I'm inclined to leave it.  I think many of these plugin packages should
> not be propagating the package that they plug into anyway.
> 
> LGTM!

OK, patch pushed.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-04-09 21:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 21:24 bug#40528: 'guix lint' does not check whether propagated-inputs should be native Marius Bakke
2020-04-09 21:31 ` Efraim Flashner
2020-04-09 21:42   ` Marius Bakke
2020-04-09 21:50     ` Efraim Flashner [this message]
2020-04-10  8:51       ` Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409215010.GY1518@E5400 \
    --to=efraim@flashner.co.il \
    --cc=40528-done@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).