From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: bug#40528: 'guix lint' does not check whether propagated-inputs should be native Date: Fri, 10 Apr 2020 00:50:10 +0300 Message-ID: <20200409215010.GY1518@E5400> References: <87h7xsjqt2.fsf@devup.no> <20200409213131.GX1518@E5400> <87eeswjpz9.fsf@devup.no> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1ugEqy3masBx2OgH" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:46337) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMf4h-00035w-4C for bug-guix@gnu.org; Thu, 09 Apr 2020 17:51:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMf4g-0006Dx-89 for bug-guix@gnu.org; Thu, 09 Apr 2020 17:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43037) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jMf4g-0006Dc-5S for bug-guix@gnu.org; Thu, 09 Apr 2020 17:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jMf4f-00050G-TH for bug-guix@gnu.org; Thu, 09 Apr 2020 17:51:01 -0400 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: Content-Disposition: inline In-Reply-To: <87eeswjpz9.fsf@devup.no> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Marius Bakke Cc: 40528-done@debbugs.gnu.org --1ugEqy3masBx2OgH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote: > Efraim Flashner writes: >=20 > > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote: > >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field = of > >> a package, not propagated-inputs. > > > > The attached patch should add the propagated inputs to the list of > > inputs to check. Do we want to start telling it to ignore some of them? >=20 > Wow, that was incredibly fast! >=20 > > gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose' s= hould probably be a native input >=20 > I'm inclined to leave it. I think many of these plugin packages should > not be propagating the package that they plug into anyway. >=20 > LGTM! OK, patch pushed. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --1ugEqy3masBx2OgH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl6PmJIACgkQQarn3Mo9 g1EOlxAArJJNcsLXvMz/d5+U6QMRQgzNgpWkF6CbTfg1RnJO7b4bbbaItQStdq/M wtogQzWMu2zNKGeyeQ6E9Ig/e/7s4aoMA8AQ2eK8QGbGSB/egvaGnidoEGQG1KwN OBcu/icFToSS5k6ScLjDvf+zWKyXrxxW4GFZQVQqf4dy987vJCky649pw8zHNDGS Ho2OtLo9YsVm6vhQIsXbvCreALlff8DlpO4+waUqrHqxJgiGHB1y651OTTeOyPXQ HYi0SNhSAYJpnRdfS7h1kNnrhQ3gi9Fei2RTbgoOQ2FcMIl8KDhx3LEqXKaGrWex kyZW0RZStFuuCiQHqb+reF/LLSP5OMwALC6RWOOuqTME1hBUJ38gJPvd9k1OW5a0 d4agpjJHi/yQW91ZObk7cVxQ/nLSvVs+S++2faUJu5hGo/K1/YCmB7nP5bo93Iwt lX04dknNdWK6BShpFor3NPCRtwnclLrsC53kw0nlXPIGtOsuNRWgZgdzOylA4K6S G8kzDV7hq5mTrcGfbR3tgMUbihI4G9OpLH8D7GeOCRR2aVRkYTaa5lwQK/Kd9zX0 htCemwEWE1GhB97hCfusmuPKX1mz6tkomiJD6VUYjJJbhWG8/sAPAxsJ+MFbOpYX ArLKAGvNJRUl2+V2EKPmIf/8pfF3nDT9xvodLtmDc1nApBKwrd0= =zknw -----END PGP SIGNATURE----- --1ugEqy3masBx2OgH--