unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#38054: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.)
       [not found]       ` <20191216014411.GC1392584@sax.terramar.selidor.net>
@ 2019-12-19 13:03         ` Efraim Flashner
  2019-12-19 16:51           ` Ivan Vilata i Balaguer
  0 siblings, 1 reply; 5+ messages in thread
From: Efraim Flashner @ 2019-12-19 13:03 UTC (permalink / raw)
  To: Ivan Vilata i Balaguer; +Cc: 38054-done, 38395-done

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

I merged the two patches together, made sure all the phases returned #t
and flushed out the commit message some more.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* bug#38054: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.)
  2019-12-19 13:03         ` bug#38054: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Efraim Flashner
@ 2019-12-19 16:51           ` Ivan Vilata i Balaguer
  2019-12-20 16:07             ` Ivan Vilata i Balaguer
  0 siblings, 1 reply; 5+ messages in thread
From: Ivan Vilata i Balaguer @ 2019-12-19 16:51 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 38054-done, 38395-done, Ivan Vilata i Balaguer

Efraim Flashner (2019-12-19 15:03:11 +0200) wrote:

> I merged the two patches together, made sure all the phases returned #t
> and flushed out the commit message some more.

Thanks a lot!  Comparing your final patch against mine was also very
instructive. `:)`

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

^ permalink raw reply	[flat|nested] 5+ messages in thread
* bug#38054: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.)
  2019-12-19 16:51           ` Ivan Vilata i Balaguer
@ 2019-12-20 16:07             ` Ivan Vilata i Balaguer
  2019-12-22 10:56               ` Efraim Flashner
  0 siblings, 1 reply; 5+ messages in thread
From: Ivan Vilata i Balaguer @ 2019-12-20 16:07 UTC (permalink / raw)
  To: Ivan Vilata i Balaguer; +Cc: 38054-done, 38395-done

Ivan Vilata i Balaguer (2019-12-19 11:51:55 -0500) wrote:

> Efraim Flashner (2019-12-19 15:03:11 +0200) wrote:
> 
> > I merged the two patches together, made sure all the phases returned #t
> > and flushed out the commit message some more.
> 
> Thanks a lot!  Comparing your final patch against mine was also very
> instructive. `:)`

Before you close this issue, I upgraded my `mumble` package and many icons are
missing.  I didn't yet have time to further investigate it, but maybe it's
because of a difference I noticed between your patch:

    (modify-phases %standard-phases

and mine:

    (modify-phases (@ (guix build qt-build-system) %standard-phases)

So maybe the problem is that the final, wrapping phase of `qt-build-system` is
not being run.  Actually I see that `mumble` is a plain binary while in the
output from my patch, it was a wrapper script.

Thanks!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

^ permalink raw reply	[flat|nested] 5+ messages in thread
* bug#38054: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.)
  2019-12-20 16:07             ` Ivan Vilata i Balaguer
@ 2019-12-22 10:56               ` Efraim Flashner
  2019-12-22 18:16                 ` Ivan Vilata i Balaguer
  0 siblings, 1 reply; 5+ messages in thread
From: Efraim Flashner @ 2019-12-22 10:56 UTC (permalink / raw)
  To: Ivan Vilata i Balaguer; +Cc: 38054-done, 38395-done

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

On Fri, Dec 20, 2019 at 11:07:58AM -0500, Ivan Vilata i Balaguer wrote:
> Ivan Vilata i Balaguer (2019-12-19 11:51:55 -0500) wrote:
> 
> > Efraim Flashner (2019-12-19 15:03:11 +0200) wrote:
> > 
> > > I merged the two patches together, made sure all the phases returned #t
> > > and flushed out the commit message some more.
> > 
> > Thanks a lot!  Comparing your final patch against mine was also very
> > instructive. `:)`
> 
> Before you close this issue, I upgraded my `mumble` package and many icons are
> missing.  I didn't yet have time to further investigate it, but maybe it's
> because of a difference I noticed between your patch:
> 
>     (modify-phases %standard-phases
> 
> and mine:
> 
>     (modify-phases (@ (guix build qt-build-system) %standard-phases)
> 
> So maybe the problem is that the final, wrapping phase of `qt-build-system` is
> not being run.  Actually I see that `mumble` is a plain binary while in the
> output from my patch, it was a wrapper script.
> 

I'm not sure what happened with the wrapping phase, but I changed it
back and now everything should be working as expected.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* bug#38054: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.)
  2019-12-22 10:56               ` Efraim Flashner
@ 2019-12-22 18:16                 ` Ivan Vilata i Balaguer
  0 siblings, 0 replies; 5+ messages in thread
From: Ivan Vilata i Balaguer @ 2019-12-22 18:16 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 38054-done, 38395-done, Ivan Vilata i Balaguer

Efraim Flashner (2019-12-22 12:56:04 +0200) wrote:

> On Fri, Dec 20, 2019 at 11:07:58AM -0500, Ivan Vilata i Balaguer wrote:
> > 
> > Before you close this issue, I upgraded my `mumble` package and many icons are
> > missing.  I didn't yet have time to further investigate it, but maybe it's
> > because of a difference I noticed between your patch:
> > 
> >     (modify-phases %standard-phases
> > 
> > and mine:
> > 
> >     (modify-phases (@ (guix build qt-build-system) %standard-phases)
> > 
> > So maybe the problem is that the final, wrapping phase of `qt-build-system` is
> > not being run.  Actually I see that `mumble` is a plain binary while in the
> > output from my patch, it was a wrapper script.
> 
> I'm not sure what happened with the wrapping phase, but I changed it
> back and now everything should be working as expected.

Works indeed now, than you! `:)`

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-22 18:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191127014038.GD17004@sax.terramar.selidor.net>
     [not found] ` <handler.38395.B.157481938629139.ack@debbugs.gnu.org>
     [not found]   ` <20191204201718.GA17141@sax.terramar.selidor.net>
     [not found]     ` <20191205090236.GQ15280@E5400>
     [not found]       ` <20191216014411.GC1392584@sax.terramar.selidor.net>
2019-12-19 13:03         ` bug#38054: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Efraim Flashner
2019-12-19 16:51           ` Ivan Vilata i Balaguer
2019-12-20 16:07             ` Ivan Vilata i Balaguer
2019-12-22 10:56               ` Efraim Flashner
2019-12-22 18:16                 ` Ivan Vilata i Balaguer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).