From: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Mathieu Othacehe <m.othacehe@gmail.com>,
35722-done@debbugs.gnu.org, Graham Lee <graham@iamleeg.com>
Subject: bug#35722: Filesystem error in the installer
Date: Tue, 14 May 2019 18:50:08 +0200 [thread overview]
Message-ID: <20190514185008.768fcc9c@scratchpost.org> (raw)
In-Reply-To: <871s11yp5b.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
> Anyway I think this is fixed by commit
> 628d09ae53047ea666f4f84ae5e5be911647fe8c, which Danny just pushed. :-)
Yeah, but I fixed it by adding the file system type--which is kinda a sledgehammer
approach. We really don't want to include every file system known to man in the
installer. In this case we had fat32 already--which uses the same package as
fat16 anyway.
Maybe it would be better long term to make it impossible to edit those
entries that we don't know how to handle, while still not crashing/restarting
the installer.
Right now, gnu/installer/newt/partition.scm:604 (listbox-action) will fail
because partition->user-partition fails. The former should probably be
modified such that it just shows an error message dialog (without
stacktrace) and lets the user continue on his way after he dismisses it.
Unfortunately, I don't know enough about newt to do that myself.
The naming throws me off, too. What's a user-partition compared to a
partition? *scratches head*
partition-filesystem-user-type does some manual mapping of parted
file system names to "user" names (that's what actually fails).
Sounds like a lot of extra complexity to me. Is it worth it?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-14 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 22:01 bug#35722: Filesystem error in the installer Graham Lee
2019-05-14 16:30 ` Ludovic Courtès
2019-05-14 16:50 ` Danny Milosavljevic [this message]
2019-05-14 17:00 ` Danny Milosavljevic
2019-05-14 17:37 ` Graham Lee
2019-05-14 18:42 ` Danny Milosavljevic
2019-05-14 18:20 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514185008.768fcc9c@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=35722-done@debbugs.gnu.org \
--cc=graham@iamleeg.com \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).