From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: bug#35722: Filesystem error in the installer Date: Tue, 14 May 2019 18:50:08 +0200 Message-ID: <20190514185008.768fcc9c@scratchpost.org> References: <63bd426cd2764658e6c1b5379544d7993c8ddc4a.camel@iamleeg.com> <871s11yp5b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/jF0==yq7NDQs.PhpSGiF55S"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:47791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQads-0006gE-30 for bug-guix@gnu.org; Tue, 14 May 2019 12:51:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQadq-0002Fc-Gf for bug-guix@gnu.org; Tue, 14 May 2019 12:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36181) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQadq-0002F5-Dk for bug-guix@gnu.org; Tue, 14 May 2019 12:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQadq-0007k9-5j for bug-guix@gnu.org; Tue, 14 May 2019 12:51:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <871s11yp5b.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" Cc: Mathieu Othacehe , 35722-done@debbugs.gnu.org, Graham Lee --Sig_/jF0==yq7NDQs.PhpSGiF55S Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable > Anyway I think this is fixed by commit > 628d09ae53047ea666f4f84ae5e5be911647fe8c, which Danny just pushed. :-) Yeah, but I fixed it by adding the file system type--which is kinda a sledg= ehammer approach. We really don't want to include every file system known to man i= n the installer. In this case we had fat32 already--which uses the same package = as fat16 anyway. Maybe it would be better long term to make it impossible to edit those entries that we don't know how to handle, while still not crashing/restarti= ng the installer. Right now, gnu/installer/newt/partition.scm:604 (listbox-action) will fail because partition->user-partition fails. The former should probably be modified such that it just shows an error message dialog (without stacktrace) and lets the user continue on his way after he dismisses it. Unfortunately, I don't know enough about newt to do that myself. The naming throws me off, too. What's a user-partition compared to a partition? *scratches head* partition-filesystem-user-type does some manual mapping of parted file system names to "user" names (that's what actually fails). Sounds like a lot of extra complexity to me. Is it worth it? --Sig_/jF0==yq7NDQs.PhpSGiF55S Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlza8cAACgkQ5xo1VCww uqXKCgf+NbPTnLNiS83ADQkdcwYmq8JojVepa5VMSztxpQKYO5KtEsELL8HZIwse PqmuJZFaDK1aWZtYHO23bTY6aCmb4B//269sMCDuW0SuwY7rNt84EAnwOqV/FiGl jnIvynQXtlEWnFcUmOXekWLKcebU4dSSIRFxJH7AwJaHtG0A3vOhJn+tUudiiZsY kVvJTzZb+g0dNdDuI1hnrsCEIFcTgHZAXXa0WoVGSUFN61sniRpdlads8Lk9M6cA 0X5ft3t14oQ9LjPzcGjtUcht4o4M8NjDCSM5Eb+hOvVeOWiuNYJaM3L6fhWKVxUo ySu+ZWiiz+oYHaWGudXmJtk+dfIWbA== =vKZL -----END PGP SIGNATURE----- --Sig_/jF0==yq7NDQs.PhpSGiF55S--