bug#30224: 'mount -t ecryptfs ...' command refers to /bin/mount, bin/umount, etc

bug#30224: 'mount -t ecryptfs ...' command refers to /bin/mount, bin/umount, etc

[brendan.tildesley]

I noticed this a while ago but probably won't get around to fixing it, so I'm just posting a bug report.
-------------------------------------
b@ui ~$ sudo mount -t ecryptfs encrypted-dir mount-dir
Passphrase:
Select cipher:
[...]
Selection [aes]:
Select key bytes:
 1) 16
 2) 32
 3) 24
Selection [16]:
Enable plaintext passthrough (y/n) [n]:
Enable filename encryption (y/n) [n]: y
Filename Encryption Key (FNEK) Signature [...]:
Attempting to mount with the following options:
  ecryptfs_unlink_sigs
  ecryptfs_fnek_sig=[...]
  ecryptfs_key_bytes=16
  ecryptfs_cipher=aes
  ecryptfs_sig=[...]
Failed to execute /bin/mount command: No such file or directory
Error mounting eCryptfs: [-2] No such file or directory
Check your system logs; visit <http://ecryptfs.org/support.html>
-------------------------------------


There are many references  to /bin/ in the ecryptfs source code, even including  /bin/umount. for example:

-------------------------------------
b@ui ~/temp/ecryptfs-utils-111$ ag exec.*bin/
src/utils/mount.ecryptfs.c
417:            execl("/bin/mount", "mount", "-i", "--no-canonicalize", "-t", "ecryptfs", fullpath_source, fullpath_target, "-o", opts, NULL);
421:            perror("Failed to execute /bin/mount command");

src/desktop/ecryptfs-mount-private.desktop.in
4:Exec=/usr/bin/ecryptfs-mount-private

src/desktop/ecryptfs-setup-private.desktop.in
4:Exec=/usr/bin/ecryptfs-setup-private

src/utils/mount.ecryptfs_private.c
833:            execl("/bin/umount", "umount", "-i", "-l", ".", NULL);

src/pam_ecryptfs/pam_ecryptfs.c
375:                    execl("/sbin/mount.ecryptfs_private",
389:                    execl("/sbin/umount.ecryptfs_private",

-------------------------------------

bug#30224: (no subject)

[Brendan Tildesley]

bug#30224: (no subject)

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Brendan Tildesley <brendan.tildesley@openmailbox.org> ezt írta (időpont:
2018. júl. 30., H, 17:44):
 Could you elaborate on this a bit more?
i.e. what was the commit fixing the issue?
on which branch?
or we just don't notice the behavior any more?
Also, please add the title of the bug, so we can see what bug is closed
without visiting the bugtracker.

[-- Attachment #2: Type: text/html, Size: 573 bytes --]

bug#30224: (no subject)

[Brendan Tildesley]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

On 07/31/18 05:54, Gábor Boskovits wrote:
>
>
> Brendan Tildesley <brendan.tildesley@openmailbox.org
> <mailto:brendan.tildesley@openmailbox.org>> ezt írta (időpont: 2018.
> júl. 30., H, 17:44):
>  Could you elaborate on this a bit more?
> i.e. what was the commit fixing the issue?
> on which branch?
> or we just don't notice the behavior any more?
> Also, please add the title of the bug, so we can see what bug is
> closed without visiting the bugtracker.
>
Sorry, it's the first time I've closed a bug, I just learnt it could be
done by sending and email to NUMBER-close@... and sent a blank email.

The fix is contained in the commits

17a21bcf316d11bdf54ec2483abe15f60dbd7cb0

e8ec2dda08d36f3a8d17f840980ea82585d1fc38

and include only changes to the ecryptfs-utils package. I tried my best
to find all cases in the source with hard-coded paths. Feel free to
inspect it further if you like. For me at least, I'm able to mount my
ecryptfs folder with these patches.



[-- Attachment #2: Type: text/html, Size: 1867 bytes --]