bug#29984: core-updates: GRUB tests hang after file_filter_test

bug#29984: core-updates: GRUB tests hang after file_filter_test

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

While building GRUB for x86_64-linux on core-updates, the test suite
appears to hang after file_filter_test.

As far as I can see, the test suite is waiting for *something*, not
actually doing any work.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#29984: core-updates: GRUB test failures

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

Perhaps I was impatient; on Hydra, the test suite does fail after >1
hour:

[...]
PASS: file_filter_test
PASS: grub_cmd_tr
FAIL: grub_func_test
============================================================================
Testsuite summary for GRUB 2.02
============================================================================
# TOTAL: 80
# PASS:  56
# SKIP:  23
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to bug-grub@gnu.org
============================================================================
make[4]: *** [Makefile:11019: test-suite.log] Error 1
make[4]: Leaving directory '/tmp/guix-build-grub-2.02.drv-0/grub-2.02'
make[3]: *** [Makefile:11127: check-TESTS] Error 2
make[3]: Leaving directory '/tmp/guix-build-grub-2.02.drv-0/grub-2.02'
make[2]: *** [Makefile:11916: check-am] Error 2
make[2]: Leaving directory '/tmp/guix-build-grub-2.02.drv-0/grub-2.02'
make[1]: *** [Makefile:10904: check-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-grub-2.02.drv-0/grub-2.02'
make: *** [Makefile:11918: check] Error 2
phase `check' failed after 3637.0 seconds
[...]

https://hydra.gnu.org/build/2414840

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#29984: core-updates: GRUB test failures

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

On Thu, Jan 04, 2018 at 03:05:11PM -0500, Leo Famulari wrote:
> FAIL: grub_func_test

I saved the failed build tree to get at this test's log. The full
contents of the log are this line:

Functional test failure:

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#29984: core-updates: GRUB test failures

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Thu, Jan 04, 2018 at 03:05:11PM -0500, Leo Famulari wrote:
>> FAIL: grub_func_test
>
> I saved the failed build tree to get at this test's log. The full
> contents of the log are this line:
>
> Functional test failure:

Nice.  What does upstream say?  :-)

Ludo’.

bug#29984: core-updates: GRUB test failures

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

On Mon, Jan 08, 2018 at 11:56:47AM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > On Thu, Jan 04, 2018 at 03:05:11PM -0500, Leo Famulari wrote:
> >> FAIL: grub_func_test
> >
> > I saved the failed build tree to get at this test's log. The full
> > contents of the log are this line:
> >
> > Functional test failure:
> 
> Nice.  What does upstream say?  :-)

I'm working on this today; I'll send them a bug report soon.

I'm going to try skipping the tests to see if this GRUB can boot a
system, and I'm also going to try running the tests on the latest commit
from the upstream Git repo.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#29984: core-updates: GRUB test failures

[Mark H Weaver]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Jan 08, 2018 at 11:56:47AM +0100, Ludovic Courtès wrote:
>> Leo Famulari <leo@famulari.name> skribis:
>> 
>> > On Thu, Jan 04, 2018 at 03:05:11PM -0500, Leo Famulari wrote:
>> >> FAIL: grub_func_test
>> >
>> > I saved the failed build tree to get at this test's log. The full
>> > contents of the log are this line:
>> >
>> > Functional test failure:
>> 
>> Nice.  What does upstream say?  :-)
>
> I'm working on this today; I'll send them a bug report soon.
>
> I'm going to try skipping the tests to see if this GRUB can boot a
> system, and I'm also going to try running the tests on the latest commit
> from the upstream Git repo.

I believe this is now fixed, by commit
0a2a70539bdf42d59c9be5fcbc88a1c14743303a on core-updates.

The problem turned out to be that GRUB's build system couldn't find
'freetype', because 'pkg-config' was missing from the build environment.
This disabled font generation, as I discovered when I booted into a
core-updates system and found that GRUB was unable to find its font.

After I fixed that problem, I was pleased to find that the test suite
started succeeding again as well :)

I'm closing this bug now.

      Mark

bug#29984: core-updates: GRUB test failures

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Mon, Jan 08, 2018 at 11:56:47AM +0100, Ludovic Courtès wrote:
>>> Leo Famulari <leo@famulari.name> skribis:
>>> 
>>> > On Thu, Jan 04, 2018 at 03:05:11PM -0500, Leo Famulari wrote:
>>> >> FAIL: grub_func_test
>>> >
>>> > I saved the failed build tree to get at this test's log. The full
>>> > contents of the log are this line:
>>> >
>>> > Functional test failure:
>>> 
>>> Nice.  What does upstream say?  :-)
>>
>> I'm working on this today; I'll send them a bug report soon.
>>
>> I'm going to try skipping the tests to see if this GRUB can boot a
>> system, and I'm also going to try running the tests on the latest commit
>> from the upstream Git repo.
>
> I believe this is now fixed, by commit
> 0a2a70539bdf42d59c9be5fcbc88a1c14743303a on core-updates.
>
> The problem turned out to be that GRUB's build system couldn't find
> 'freetype', because 'pkg-config' was missing from the build environment.
> This disabled font generation, as I discovered when I booted into a
> core-updates system and found that GRUB was unable to find its font.
>
> After I fixed that problem, I was pleased to find that the test suite
> started succeeding again as well :)

Oh, good catch!

Looks like ‘core-updates’ is getting close to ready…

Thanks,
Ludo’.

bug#29984: core-updates: GRUB test failures

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

On Mon, Jan 29, 2018 at 07:12:35AM -0500, Mark H Weaver wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Mon, Jan 08, 2018 at 11:56:47AM +0100, Ludovic Courtès wrote:
> >> Leo Famulari <leo@famulari.name> skribis:
> >> 
> >> > On Thu, Jan 04, 2018 at 03:05:11PM -0500, Leo Famulari wrote:
> >> >> FAIL: grub_func_test
> >> >
> >> > I saved the failed build tree to get at this test's log. The full
> >> > contents of the log are this line:
> >> >
> >> > Functional test failure:
> >> 
> >> Nice.  What does upstream say?  :-)
> >
> > I'm working on this today; I'll send them a bug report soon.
> >
> > I'm going to try skipping the tests to see if this GRUB can boot a
> > system, and I'm also going to try running the tests on the latest commit
> > from the upstream Git repo.
> 
> I believe this is now fixed, by commit
> 0a2a70539bdf42d59c9be5fcbc88a1c14743303a on core-updates.
> 
> The problem turned out to be that GRUB's build system couldn't find
> 'freetype', because 'pkg-config' was missing from the build environment.
> This disabled font generation, as I discovered when I booted into a
> core-updates system and found that GRUB was unable to find its font.
> 
> After I fixed that problem, I was pleased to find that the test suite
> started succeeding again as well :)

Wow, I never would have guessed this was the issue!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]