unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 27735@debbugs.gnu.org
Subject: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label.
Date: Tue, 18 Jul 2017 15:48:45 +0200	[thread overview]
Message-ID: <20170718154845.5cd79c48@scratchpost.org> (raw)
In-Reply-To: <d106fcb3-8ac0-214f-f1c7-4860c38014aa@tobias.gr>

Hi T G-R,
Hi Ludo,

On Tue, 18 Jul 2017 14:30:10 +0200
Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> On 18/07/17 12:09, Ludovic Courtès wrote:
> > Can we do ‘string-map’ to replace dash with underscore, just like we did
> > ‘normalize-label’?  

Yes.

> That would have been a better approach. :-)

I disagree that that would be better.  Every map is a source of error and also makes it difficult to follow what is going on (i.e. difficult to maintain).

Best is only to use the common intersection of all the valid charsets and not map anything to anything else.

We can map it and it's OK but it's not good in the long run.  I've learnt that the hard way over many years.

But since we do string-upcase already, it doesn't matter anymore.  Better hope we don't break it by accident one day (or right away), though.

  reply	other threads:[~2017-07-18 13:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 14:40 bug#27735: Unbootable images with GuixSD on... "GuixSD" Tobias Geerinckx-Rice
2017-07-17 14:51 ` bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label Tobias Geerinckx-Rice
2017-07-17 17:20   ` Danny Milosavljevic
2017-07-17 17:58     ` Tobias Geerinckx-Rice
2017-07-18 10:09     ` Ludovic Courtès
2017-07-18 12:30       ` Tobias Geerinckx-Rice
2017-07-18 13:48         ` Danny Milosavljevic [this message]
2017-07-17 17:17 ` bug#27735: Unbootable images with GuixSD on... "GuixSD" Danny Milosavljevic
2017-07-17 18:12   ` Tobias Geerinckx-Rice
2017-07-17 18:37     ` Tobias Geerinckx-Rice
2017-07-18 11:49   ` Ludovic Courtès
2017-07-18 15:09     ` Tobias Geerinckx-Rice
2017-07-18 18:59       ` Ludovic Courtès
2017-07-18 20:42         ` Tobias Geerinckx-Rice
2017-07-19 19:11     ` Danny Milosavljevic
2017-07-19 22:32       ` bug#27735: Lookup by UUID Ludovic Courtès
2017-07-20 17:38         ` Danny Milosavljevic
2017-07-20 20:32           ` Ludovic Courtès
2017-07-20 21:51             ` Danny Milosavljevic
2017-08-05 17:50             ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718154845.5cd79c48@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=27735@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).