From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label.
Date: Tue, 18 Jul 2017 15:48:45 +0200
Message-ID: <20170718154845.5cd79c48@scratchpost.org>
References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr>
	<20170717145151.12222-1-me@tobias.gr>
	<20170717192038.5b19d711@scratchpost.org> <87lgnm12gx.fsf@gnu.org>
	<d106fcb3-8ac0-214f-f1c7-4860c38014aa@tobias.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dXSs2-0007ja-Vb
	for bug-guix@gnu.org; Tue, 18 Jul 2017 09:49:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dXSs2-0003Fk-6d
	for bug-guix@gnu.org; Tue, 18 Jul 2017 09:49:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42877)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dXSs2-0003FB-2y
	for bug-guix@gnu.org; Tue, 18 Jul 2017 09:49:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dXSs1-0002ZO-PQ
	for bug-guix@gnu.org; Tue, 18 Jul 2017 09:49:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27735.B27735.15003857379868@debbugs.gnu.org>
In-Reply-To: <d106fcb3-8ac0-214f-f1c7-4860c38014aa@tobias.gr>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 27735@debbugs.gnu.org

Hi T G-R,
Hi Ludo,

On Tue, 18 Jul 2017 14:30:10 +0200
Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> On 18/07/17 12:09, Ludovic Court=C3=A8s wrote:
> > Can we do =E2=80=98string-map=E2=80=99 to replace dash with underscore,=
 just like we did
> > =E2=80=98normalize-label=E2=80=99? =20

Yes.

> That would have been a better approach. :-)

I disagree that that would be better.  Every map is a source of error and a=
lso makes it difficult to follow what is going on (i.e. difficult to mainta=
in).

Best is only to use the common intersection of all the valid charsets and n=
ot map anything to anything else.

We can map it and it's OK but it's not good in the long run.  I've learnt t=
hat the hard way over many years.

But since we do string-upcase already, it doesn't matter anymore.  Better h=
ope we don't break it by accident one day (or right away), though.