From: Danny Milosavljevic <dannym@scratchpost.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 25917@debbugs.gnu.org
Subject: bug#25917: [PATCH] file-systems: Factorize file-system-packages.
Date: Fri, 17 Mar 2017 13:19:58 +0100 [thread overview]
Message-ID: <20170317131958.734cdfba@scratchpost.org> (raw)
In-Reply-To: <87efxwi8av.fsf@gnu.org>
Hi Ludo,
On Fri, 17 Mar 2017 10:03:52 +0100
ludo@gnu.org (Ludovic Courtès) wrote:
> You can also remove the now-unused ‘file-system-type-predicate’
> procedure that is in ‘base-initrd’.
It's still used there (in order to determine the Linux modules). Should I also export 'file-system-type-predicate` from file-systems.scm and use that in 'base-initrd` ? I thought it was too special-case to be a public function.
Also, it seems that the new version (which now uses `set-path-environment-variable') clears the old PATH whereas the previous version prepended to it.
The previous version has:
(setenv "PATH"
(string-append
#$e2fsprogs "/sbin:"
"/run/current-system/profile/sbin:"
$PATH)))
(What does "$" without "#" do?)
The new version would have:
(lambda ()
(set-path-environment-variable "PATH"
'("bin" "sbin")
'#$packages))
It works fine - however, I get a warning that PATH has been unset at bootup.
Should we replicate the previous behaviour?
What's up with the hard-coded "/run/current-system/profile/sbin" ?
next prev parent reply other threads:[~2017-03-17 12:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 16:38 bug#25917: operating-system file-system with (check? #t) but (needed-for-boot #f) pauses boot until user interaction Danny Milosavljevic
2017-03-11 11:21 ` Ludovic Courtès
2017-03-12 16:56 ` bug#25917: [PATCH] services: Don't check filesystem even if #:check? if not #:needed-for-boot Danny Milosavljevic
2017-03-13 9:01 ` Ludovic Courtès
2017-03-13 19:55 ` Danny Milosavljevic
2017-03-14 8:41 ` Ludovic Courtès
2017-03-14 19:18 ` Danny Milosavljevic
2017-03-14 20:18 ` Ludovic Courtès
2017-03-12 16:59 ` bug#25917: [PATCH v2] services: If a filesystem is not marked as needed for boot, don't check it even if told to check it Danny Milosavljevic
2017-03-16 17:40 ` bug#25917: [PATCH] file-systems: Factorize file-system-packages Danny Milosavljevic
2017-03-17 9:03 ` Ludovic Courtès
2017-03-17 12:19 ` Danny Milosavljevic [this message]
2017-03-18 11:00 ` Ludovic Courtès
2017-03-18 11:04 ` Ludovic Courtès
2017-03-18 9:42 ` Danny Milosavljevic
2017-03-18 14:06 ` bug#25917: [PATCH v2] services: file-system-shepherd-service: Make it find the fsck programs Danny Milosavljevic
2017-03-19 15:44 ` Ludovic Courtès
2017-04-22 23:34 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317131958.734cdfba@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=25917@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).