From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#25917: [PATCH] file-systems: Factorize file-system-packages.
Date: Fri, 17 Mar 2017 13:19:58 +0100
Message-ID: <20170317131958.734cdfba@scratchpost.org>
References: <20170316174029.1663-1-dannym@scratchpost.org>
	<87efxwi8av.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40525)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1coqsT-0008L3-FI
	for bug-guix@gnu.org; Fri, 17 Mar 2017 08:21:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1coqsQ-0006PG-3N
	for bug-guix@gnu.org; Fri, 17 Mar 2017 08:21:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33317)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1coqsQ-0006Oy-0a
	for bug-guix@gnu.org; Fri, 17 Mar 2017 08:21:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1coqsP-0004yw-Qy
	for bug-guix@gnu.org; Fri, 17 Mar 2017 08:21:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25917.B25917.148975320519074@debbugs.gnu.org>
In-Reply-To: <87efxwi8av.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 25917@debbugs.gnu.org

Hi Ludo,

On Fri, 17 Mar 2017 10:03:52 +0100
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> You can also remove the now-unused =E2=80=98file-system-type-predicate=E2=
=80=99
> procedure that is in =E2=80=98base-initrd=E2=80=99.

It's still used there (in order to determine the Linux modules).  Should I =
also export 'file-system-type-predicate` from file-systems.scm and use that=
 in 'base-initrd` ?  I thought it was too special-case to be a public funct=
ion.

Also, it seems that the new version (which now uses `set-path-environment-v=
ariable') clears the old PATH whereas the previous version prepended to it.

The previous version has:

                             (setenv "PATH"
                                     (string-append
                                      #$e2fsprogs "/sbin:"
                                      "/run/current-system/profile/sbin:"
                                      $PATH)))

(What does "$" without "#" do?)

The new version would have:

                           (lambda ()
                             (set-path-environment-variable "PATH"
                                                            '("bin" "sbin")
                                                            '#$packages))

It works fine - however, I get a warning that PATH has been unset at bootup.

Should we replicate the previous behaviour?

What's up with the hard-coded "/run/current-system/profile/sbin" ?