unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: Hartmut Goebel <h.goebel@crazy-compilers.com>, 25177@debbugs.gnu.org
Subject: bug#25177: Test failures don't cause some Python packages to fail	[was Re: [PATCH 05/11] gnu: Add python-pygit2.]
Date: Mon, 12 Dec 2016 10:44:12 -0500	[thread overview]
Message-ID: <20161212154412.GA25907@jasmine> (raw)
In-Reply-To: <87mvg1k2f3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On Mon, Dec 12, 2016 at 08:54:40AM +0100, Marius Bakke wrote:
> The good news: the attached patch makes 'check' work as expected. The
> bad news is that we have some breakages.
> 
> 'python-py' fails with:
> 
> TypeError: py.test.__dict__ is not a dictionary
> 
> Which seems similar to
> 
> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144

Yikes, I had hoped to avoid addressing that Nix issue and the humongous
"fix" for a while longer:

https://github.com/NixOS/nixpkgs/pull/12552

> I tried adding a newer setuptools as input, to no avail. Needs more
> investigation.

Okay, I'm happy to hear that it didn't work ;) My understanding is that
with the new python-build-system, packages are built with the setuptools
that comes with Python, not the external python-setuptools package.

Please let us know what you find.

Hartmut, any thoughts?

In any case, I think it's time to start working on a 'python-updates'
branch, which could include this patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2016-12-12 15:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161211181237.24485-1-ng0@libertad.pw>
     [not found] ` <20161211181237.24485-6-ng0@libertad.pw>
2016-12-11 22:34   ` bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.] Leo Famulari
2016-12-11 23:04     ` Marius Bakke
2016-12-11 23:05       ` Marius Bakke
2016-12-11 23:23         ` Leo Famulari
2016-12-11 23:34           ` Marius Bakke
2016-12-12  7:54       ` Marius Bakke
2016-12-12 15:44         ` Leo Famulari [this message]
2016-12-12 22:23           ` Hartmut Goebel
2016-12-13  9:34             ` Marius Bakke
2016-12-13 20:21               ` bug#25177: Test failures don't cause some Python packages to fail Marius Bakke
2016-12-13 22:11                 ` Leo Famulari
2016-12-14 12:11                   ` Marius Bakke
2016-12-15  9:26                   ` Marius Bakke
2016-12-15 23:55                     ` Leo Famulari
2016-12-16 14:02                       ` Marius Bakke
2016-12-17 17:14                         ` Leo Famulari
2016-12-17 17:38                           ` Marius Bakke
2016-12-17 17:56                             ` Leo Famulari
2016-12-17 20:15                               ` Leo Famulari
2016-12-17 23:47                                 ` Marius Bakke
2016-12-18  1:28                                   ` Leo Famulari
2016-12-18 18:55                                     ` Marius Bakke
2016-12-18 19:04                                       ` Leo Famulari
2016-12-20 18:49                                         ` Marius Bakke
2016-12-20 19:30                                           ` Leo Famulari
2016-12-24 13:43                                             ` Marius Bakke
2016-12-24 16:26                                               ` Leo Famulari
2016-12-26 18:33                                                 ` Leo Famulari
2016-12-16  9:23                     ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161212154412.GA25907@jasmine \
    --to=leo@famulari.name \
    --cc=25177@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).