unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#24442: gettext: No PO mode for Emacs (or wrong description)
@ 2016-09-15  7:04 Ivan Vilata i Balaguer
  2016-09-19  8:58 ` Alex Kost
  2016-09-29  8:03 ` Alex Kost
  0 siblings, 2 replies; 8+ messages in thread
From: Ivan Vilata i Balaguer @ 2016-09-15  7:04 UTC (permalink / raw)
  To: 24442

The description for ``gettext@0.19.8`` (current) includes this sentence:

    It provides translators with the means to create message catalogs,
    as well as an Emacs mode to work with them, and a runtime library to
    load translated messages from the catalogs.

However, no output of the package includes the files for Emacs.

One solution (please note that I'm very new to Guix) may be to provide
an output for the Emacs goodies, another one would be removing the
reference to the Emacs mode in the description until it's actually
there.`;)`

Thanks!
-- 
Ivan Vilata i Balaguer -- https://elvil.net/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#24442: gettext: No PO mode for Emacs (or wrong description)
  2016-09-15  7:04 bug#24442: gettext: No PO mode for Emacs (or wrong description) Ivan Vilata i Balaguer
@ 2016-09-19  8:58 ` Alex Kost
  2016-09-24  1:55   ` Ludovic Courtès
  2016-09-29  8:03 ` Alex Kost
  1 sibling, 1 reply; 8+ messages in thread
From: Alex Kost @ 2016-09-19  8:58 UTC (permalink / raw)
  To: Ivan Vilata i Balaguer; +Cc: 24442

Ivan Vilata i Balaguer (2016-09-15 09:04 +0200) wrote:

> The description for ``gettext@0.19.8`` (current) includes this sentence:
>
>     It provides translators with the means to create message catalogs,
>     as well as an Emacs mode to work with them, and a runtime library to
>     load translated messages from the catalogs.
>
> However, no output of the package includes the files for Emacs.

Thanks for the report!  This happens because there is no emacs
dependency (input) in 'gettext' package definition, so Emacs is not
found during 'configure' phase (as can be seen in the log¹: «checking
for emacs... no»), so elisp files are not compiled and installed.

I would say this can simply be fixed by adding:

  (native-inputs `(("emacs" ,emacs-minimal)))

to the gettext package definition (also (gnu packages emacs) module
should be used), and I checked it by making a variant of the gettext
package with this line; however when I tried it on a real gettext
package, I saw that a whole world will be rebuilt (apparently it is a
'core-updates' thing).  And I realized that emacs (even its minimal
variant) will probably be a too heavy dependency for such a core thing.

So perhaps it is time to make 'gettext-minimal' and to use it as the
dependency for other packages and 'gettext' (with Emacs tools) intended
to be installed by users (as it is done for bash/bash-minimal).  WDYT?
(this is a question for Guix developers)

> One solution (please note that I'm very new to Guix) may be to provide
> an output for the Emacs goodies, another one would be removing the
> reference to the Emacs mode in the description until it's actually
> there.`;)`

I think a special output is not needed, as the resulting *.el[c] files
weigh much less than 1MB.

¹ http://hydra.gnu.org/log/1zxiq8gq3gs29j0gha5ciyklfafkkrmd-gettext-0.19.8

-- 
Alex

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#24442: gettext: No PO mode for Emacs (or wrong description)
  2016-09-19  8:58 ` Alex Kost
@ 2016-09-24  1:55   ` Ludovic Courtès
  2016-09-25  8:09     ` Alex Kost
  0 siblings, 1 reply; 8+ messages in thread
From: Ludovic Courtès @ 2016-09-24  1:55 UTC (permalink / raw)
  To: Alex Kost; +Cc: 24442

Hi!

Alex Kost <alezost@gmail.com> skribis:

> Ivan Vilata i Balaguer (2016-09-15 09:04 +0200) wrote:
>
>> The description for ``gettext@0.19.8`` (current) includes this sentence:
>>
>>     It provides translators with the means to create message catalogs,
>>     as well as an Emacs mode to work with them, and a runtime library to
>>     load translated messages from the catalogs.
>>
>> However, no output of the package includes the files for Emacs.
>
> Thanks for the report!  This happens because there is no emacs
> dependency (input) in 'gettext' package definition, so Emacs is not
> found during 'configure' phase (as can be seen in the log¹: «checking
> for emacs... no»), so elisp files are not compiled and installed.
>
> I would say this can simply be fixed by adding:
>
>   (native-inputs `(("emacs" ,emacs-minimal)))
>
> to the gettext package definition (also (gnu packages emacs) module
> should be used), and I checked it by making a variant of the gettext
> package with this line; however when I tried it on a real gettext
> package, I saw that a whole world will be rebuilt (apparently it is a
> 'core-updates' thing).  And I realized that emacs (even its minimal
> variant) will probably be a too heavy dependency for such a core thing.
>
> So perhaps it is time to make 'gettext-minimal' and to use it as the
> dependency for other packages and 'gettext' (with Emacs tools) intended
> to be installed by users (as it is done for bash/bash-minimal).  WDYT?
> (this is a question for Guix developers)

I think it’s a good idea; in commencement.scm, we’ll need to inherit
from gettext-minimal to avoid the Emacs dependency.

Most of the packages that currently depend on gettext will have to be
changed to gettext-minimal, as you wrote.

When that it’s done, we can happily add all sorts of dependencies to
gettext, including additional languages for which it provides bindings.

Sounds like a plan no?

Another option would be to hack a phase that copies the .el files to the
output, without compiling them, but I don’t think it’s as nice as the
above plan.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#24442: gettext: No PO mode for Emacs (or wrong description)
  2016-09-24  1:55   ` Ludovic Courtès
@ 2016-09-25  8:09     ` Alex Kost
  0 siblings, 0 replies; 8+ messages in thread
From: Alex Kost @ 2016-09-25  8:09 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 24442

Ludovic Courtès (2016-09-24 10:55 +0900) wrote:

> Hi!
>
> Alex Kost <alezost@gmail.com> skribis:
>
>> Ivan Vilata i Balaguer (2016-09-15 09:04 +0200) wrote:
>>
>>> The description for ``gettext@0.19.8`` (current) includes this sentence:
>>>
>>>     It provides translators with the means to create message catalogs,
>>>     as well as an Emacs mode to work with them, and a runtime library to
>>>     load translated messages from the catalogs.
>>>
>>> However, no output of the package includes the files for Emacs.
>>
>> Thanks for the report!  This happens because there is no emacs
>> dependency (input) in 'gettext' package definition, so Emacs is not
>> found during 'configure' phase (as can be seen in the log¹: «checking
>> for emacs... no»), so elisp files are not compiled and installed.
>>
>> I would say this can simply be fixed by adding:
>>
>>   (native-inputs `(("emacs" ,emacs-minimal)))
>>
>> to the gettext package definition (also (gnu packages emacs) module
>> should be used), and I checked it by making a variant of the gettext
>> package with this line; however when I tried it on a real gettext
>> package, I saw that a whole world will be rebuilt (apparently it is a
>> 'core-updates' thing).  And I realized that emacs (even its minimal
>> variant) will probably be a too heavy dependency for such a core thing.
>>
>> So perhaps it is time to make 'gettext-minimal' and to use it as the
>> dependency for other packages and 'gettext' (with Emacs tools) intended
>> to be installed by users (as it is done for bash/bash-minimal).  WDYT?
>> (this is a question for Guix developers)
>
> I think it’s a good idea; in commencement.scm, we’ll need to inherit
> from gettext-minimal to avoid the Emacs dependency.
>
> Most of the packages that currently depend on gettext will have to be
> changed to gettext-minimal, as you wrote.
>
> When that it’s done, we can happily add all sorts of dependencies to
> gettext, including additional languages for which it provides bindings.
>
> Sounds like a plan no?

Yes, I'm sending 2 patches to guix-devel for adding 'gettext-minimal'
and for adding missing *.el files to 'gettext'.

> Another option would be to hack a phase that copies the .el files to the
> output, without compiling them, but I don’t think it’s as nice as the
> above plan.

I agree, it doesn't look so nice.

-- 
Alex

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#24442: gettext: No PO mode for Emacs (or wrong description)
  2016-09-15  7:04 bug#24442: gettext: No PO mode for Emacs (or wrong description) Ivan Vilata i Balaguer
  2016-09-19  8:58 ` Alex Kost
@ 2016-09-29  8:03 ` Alex Kost
  2016-09-29 11:15   ` Ivan Vilata i Balaguer
  1 sibling, 1 reply; 8+ messages in thread
From: Alex Kost @ 2016-09-29  8:03 UTC (permalink / raw)
  To: Ivan Vilata i Balaguer; +Cc: 24442

Ivan Vilata i Balaguer (2016-09-15 09:04 +0200) wrote:

> The description for ``gettext@0.19.8`` (current) includes this sentence:
>
>     It provides translators with the means to create message catalogs,
>     as well as an Emacs mode to work with them, and a runtime library to
>     load translated messages from the catalogs.
>
> However, no output of the package includes the files for Emacs.

This is fixed in 'core-updates' branch now:
<http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9e01589469abd89e035450d29026f0e14add6801>,
however since the fix is not available for users (until core-updates
will be merged into master) I think it's better to leave this bug
opened.

Once the fix appears in 'master' (I will let you know when it happens),
a user could do "guix pull" and install (or update) 'gettext' in his/her
profile.  Then 'po-mode' will become available by default (without any
additional settings in user's .emacs), it means that whenever you will
open .po file, 'po-mode' will be loaded and enabled automatically.

-- 
Alex

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#24442: gettext: No PO mode for Emacs (or wrong description)
  2016-09-29  8:03 ` Alex Kost
@ 2016-09-29 11:15   ` Ivan Vilata i Balaguer
  2016-11-17 14:56     ` Ivan Vilata i Balaguer
  0 siblings, 1 reply; 8+ messages in thread
From: Ivan Vilata i Balaguer @ 2016-09-29 11:15 UTC (permalink / raw)
  To: Alex Kost; +Cc: 24442

Alex Kost (2016-09-29 11:03:41 +0300) wrote:

> Ivan Vilata i Balaguer (2016-09-15 09:04 +0200) wrote:
> 
> > The description for ``gettext@0.19.8`` (current) includes this sentence:
> >
> >     It provides translators with the means to create message
> >     catalogs, as well as an Emacs mode to work with them, and a
> >     runtime library to load translated messages from the catalogs.
> >
> > However, no output of the package includes the files for Emacs.
> 
> This is fixed in 'core-updates' branch now:
> <http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9e01589469abd89e035450d29026f0e14add6801>,
> however since the fix is not available for users (until core-updates
> will be merged into master) I think it's better to leave this bug
> opened.
> 
> Once the fix appears in 'master' (I will let you know when it
> happens), a user could do "guix pull" and install (or update)
> 'gettext' in his/her profile.  Then 'po-mode' will become available by
> default (without any additional settings in user's .emacs), it means
> that whenever you will open .po file, 'po-mode' will be loaded and
> enabled automatically.

Impressive, thanks a lot to everyone!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#24442: gettext: No PO mode for Emacs (or wrong description)
  2016-09-29 11:15   ` Ivan Vilata i Balaguer
@ 2016-11-17 14:56     ` Ivan Vilata i Balaguer
  2016-11-18  9:36       ` Ludovic Courtès
  0 siblings, 1 reply; 8+ messages in thread
From: Ivan Vilata i Balaguer @ 2016-11-17 14:56 UTC (permalink / raw)
  To: Ivan Vilata i Balaguer; +Cc: Alex Kost, 24442

Ivan Vilata i Balaguer (2016-09-29 13:15:45 +0200) wrote:

> Alex Kost (2016-09-29 11:03:41 +0300) wrote:
> 
> > Ivan Vilata i Balaguer (2016-09-15 09:04 +0200) wrote:
> > 
> > > The description for ``gettext@0.19.8`` (current) includes this sentence:
> > >
> > >     It provides translators with the means to create message
> > >     catalogs, as well as an Emacs mode to work with them, and a
> > >     runtime library to load translated messages from the catalogs.
> > >
> > > However, no output of the package includes the files for Emacs.
> > 
> > This is fixed in 'core-updates' branch now:
> > <http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9e01589469abd89e035450d29026f0e14add6801>,
> > however since the fix is not available for users (until core-updates
> > will be merged into master) I think it's better to leave this bug
> > opened.
> > 
> > Once the fix appears in 'master' (I will let you know when it
> > happens), a user could do "guix pull" and install (or update)
> > 'gettext' in his/her profile.  Then 'po-mode' will become available
> > by default (without any additional settings in user's .emacs), it
> > means that whenever you will open .po file, 'po-mode' will be loaded
> > and enabled automatically.
> 
> Impressive, thanks a lot to everyone!

Working like a charm since the last upgrade, thank you!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#24442: gettext: No PO mode for Emacs (or wrong description)
  2016-11-17 14:56     ` Ivan Vilata i Balaguer
@ 2016-11-18  9:36       ` Ludovic Courtès
  0 siblings, 0 replies; 8+ messages in thread
From: Ludovic Courtès @ 2016-11-18  9:36 UTC (permalink / raw)
  To: Ivan Vilata i Balaguer; +Cc: Alex Kost, 24442-done

Ivan Vilata i Balaguer <ivan@selidor.net> skribis:

> Ivan Vilata i Balaguer (2016-09-29 13:15:45 +0200) wrote:
>
>> Alex Kost (2016-09-29 11:03:41 +0300) wrote:
>> 
>> > Ivan Vilata i Balaguer (2016-09-15 09:04 +0200) wrote:
>> > 
>> > > The description for ``gettext@0.19.8`` (current) includes this sentence:
>> > >
>> > >     It provides translators with the means to create message
>> > >     catalogs, as well as an Emacs mode to work with them, and a
>> > >     runtime library to load translated messages from the catalogs.
>> > >
>> > > However, no output of the package includes the files for Emacs.
>> > 
>> > This is fixed in 'core-updates' branch now:
>> > <http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9e01589469abd89e035450d29026f0e14add6801>,
>> > however since the fix is not available for users (until core-updates
>> > will be merged into master) I think it's better to leave this bug
>> > opened.
>> > 
>> > Once the fix appears in 'master' (I will let you know when it
>> > happens), a user could do "guix pull" and install (or update)
>> > 'gettext' in his/her profile.  Then 'po-mode' will become available
>> > by default (without any additional settings in user's .emacs), it
>> > means that whenever you will open .po file, 'po-mode' will be loaded
>> > and enabled automatically.
>> 
>> Impressive, thanks a lot to everyone!
>
> Working like a charm since the last upgrade, thank you!

Indeed, closing!

Ludo’.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-11-18  9:37 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15  7:04 bug#24442: gettext: No PO mode for Emacs (or wrong description) Ivan Vilata i Balaguer
2016-09-19  8:58 ` Alex Kost
2016-09-24  1:55   ` Ludovic Courtès
2016-09-25  8:09     ` Alex Kost
2016-09-29  8:03 ` Alex Kost
2016-09-29 11:15   ` Ivan Vilata i Balaguer
2016-11-17 14:56     ` Ivan Vilata i Balaguer
2016-11-18  9:36       ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).