From: Maxime Devos <maximedevos@telenet.be>
To: Vagrant Cascadian <vagrant@debian.org>, 44675@debbugs.gnu.org
Subject: bug#44675: guix lint: support for spellchecker or basic grammar
Date: Thu, 22 Apr 2021 20:05:22 +0200 [thread overview]
Message-ID: <1f1a7b54fce32d0241d9f689e00cf52b5c4d48fd.camel@telenet.be> (raw)
In-Reply-To: <87o8e6nqvv.fsf@yucca>
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]
Vagrant Cascadian schreef op do 22-04-2021 om 10:57 [-0700]:
> On 2021-04-22, Maxime Devos wrote:
> > + (define (check-pluralized-this-package description)
> > + "Check that DESCRIPTION does not contain This packages"
> >
> > The sentence structure would be clearer if you used quotes here,
> > something like "Check that DESCRIPTION does not contain ‘This packages’".
>
> Any compelling reason to use ‘This packages’ vs. 'This packages' ?
I find ‘curly quotes’ more aesthetically pleasing, though that's a bit subjective
I guess.
> It seems other quotes in guix/lint.scm use '' also,
I believe they should use ‘curly quotes’ as well, though I would like to hear
what other things about that first.
> and I'm not apparently
> skilled enough with a keyboard to generate ‘’-style quotes... :)
If your keyboard is azerty, you could choose ‘Belgian alternative’, and type
‘ with alt-gr+f and ’ with alt-gr+g.
> Updated the commit message and incorporated the above suggestions into
> the updated attached patch.
One other suggestion: you used "string-match" in 'check-pluralized-this-package',
which is a bit overkill. string-match interprets its first argument as a regex.
The procedure "string-contains" is simpler and probably more efficient.
The patch looks good otherwise.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-04-22 18:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 1:53 bug#44675: guix lint: support for spellchecker or basic grammar Vagrant Cascadian
2020-11-16 5:55 ` zimoun
2021-04-21 23:10 ` Vagrant Cascadian
2021-04-22 16:42 ` Maxime Devos
2021-04-22 17:57 ` Vagrant Cascadian
2021-04-22 18:05 ` Maxime Devos [this message]
2021-05-04 16:40 ` Ludovic Courtès
2021-06-09 15:33 ` Vagrant Cascadian
2021-10-21 23:18 ` Vagrant Cascadian
2021-10-22 8:33 ` zimoun
2021-10-24 11:22 ` Vagrant Cascadian
2021-10-24 11:56 ` zimoun
2021-10-24 19:02 ` Vagrant Cascadian
2021-10-24 21:41 ` Vagrant Cascadian
2021-04-25 7:27 ` Efraim Flashner
2021-04-25 16:43 ` Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f1a7b54fce32d0241d9f689e00cf52b5c4d48fd.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=44675@debbugs.gnu.org \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).