From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OLXxAjG7gWAbgAAAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 20:06:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +EtUOjC7gWBXKgAA1q6Kng (envelope-from ) for ; Thu, 22 Apr 2021 18:06:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7ADE9177C0 for ; Thu, 22 Apr 2021 20:06:40 +0200 (CEST) Received: from localhost ([::1]:49878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZdip-0007uY-9C for larch@yhetil.org; Thu, 22 Apr 2021 14:06:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZdiF-0007tw-W8 for bug-guix@gnu.org; Thu, 22 Apr 2021 14:06:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZdiD-0002wt-R7 for bug-guix@gnu.org; Thu, 22 Apr 2021 14:06:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZdiD-0007xp-K6 for bug-guix@gnu.org; Thu, 22 Apr 2021 14:06:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44675: guix lint: support for spellchecker or basic grammar Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 22 Apr 2021 18:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44675 X-GNU-PR-Package: guix X-GNU-PR-Keywords: easy To: Vagrant Cascadian , 44675@debbugs.gnu.org Received: via spool by 44675-submit@debbugs.gnu.org id=B44675.161911473330578 (code B ref 44675); Thu, 22 Apr 2021 18:06:01 +0000 Received: (at 44675) by debbugs.gnu.org; 22 Apr 2021 18:05:33 +0000 Received: from localhost ([127.0.0.1]:35485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZdhk-0007x8-WA for submit@debbugs.gnu.org; Thu, 22 Apr 2021 14:05:33 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZdhh-0007ww-P9 for 44675@debbugs.gnu.org; Thu, 22 Apr 2021 14:05:32 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id vu5T2400d0mfAB406u5Ut3; Thu, 22 Apr 2021 20:05:28 +0200 Message-ID: <1f1a7b54fce32d0241d9f689e00cf52b5c4d48fd.camel@telenet.be> From: Maxime Devos Date: Thu, 22 Apr 2021 20:05:22 +0200 In-Reply-To: <87o8e6nqvv.fsf@yucca> References: <87ima6rrri.fsf@yucca> <87tunznsi7.fsf@yucca> <2f3077c0d040e4b40db19d98195845e124b064d3.camel@telenet.be> <87o8e6nqvv.fsf@yucca> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-2VIjVyZrhFZYcegwHDxm" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1619114728; bh=zYYf6WHmIDPN7X8ThRteBXbQnQyvnL4i0T+AEGOwaIs=; h=Subject:From:To:Date:In-Reply-To:References; b=ZB4Apa6BWJAUNhja5D2d27svC9khwFMHJO4EUlhMNKnKCzLY5LA8D0hFODZfutfQK 7acYYdDPKfyHAW/yDDvg4rxzESmx1Itx+jMw+ednonTk482hUOF1xYte1B42fwjBf6 LthKiTYdf9sAy4h9cepsvEmyAcWVRAyz4fegDQEN5gU0iIF2wWlEpjFuC8doks7h2e Bjw5UUPxivhiTJnW7v3aMDlIR/waouPnU4rUwGDrgdnPP6ffnNRrKiEO40ZZfUiCcn l/0kpnAGDNsm4UZJw2nCet/dsoE+OHPiovMJLGFlRvaZ5Oo7wJRf5pLKk2L6JtlP3g 8puwkVtiJ6ZHw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619114800; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=zYYf6WHmIDPN7X8ThRteBXbQnQyvnL4i0T+AEGOwaIs=; b=b5jd24nNeJeIfF08haD396VqiPvhzliEnMHT18ITd9N+OsBGBChrg43xmsHMwcooW+/7ya 8kjeXSJx1eNUf0lJ/vcYj/oKAZB00JxZGn98QD+eGfCBpzAo1297+5jhqCvzhiEWlbYymZ WgLO0PFFI2T4rX4Rz5+IIzIvtkdaR/PV9aTb//5RvH5tfCg6I1IgC5qxIVk3uQKx79QmS0 B07OyuaHvdaq7/mpdWnH7uY5HXEqZuPopvpyCnhWQZRqNCrNwxHfGoGOW6K6aGU1Jp3DS3 nhekvF82TPErkEFyU/d+put9kODQ04ZONrmc+iF4hGbpiUlCO8EVZ9U3Z5Ycag== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619114800; a=rsa-sha256; cv=none; b=Lywft1X8fb6ugeIT20UT51hktTvWWW3urEHvDOQiGjh56JshZ/D5x8XV2cgD6CT97l4GVn eT5+coDa9y3RcXz4zKoGKJClrsiwgnWOfrnrjhQfRkjy9Ty/qqBFkvxfHFK9PQ0xItkDAK Bgp8nLlEDeBaKEu3gxpzBb32Xk+meyZ1o14wy6BseWZTsuXt7xAatA8CYpwgySFKiUnIB6 mg5Ti/W3/nQRJ4oZLrYs+72d63XMrSp0ClC//e6fm78VQ1ZZky69+by1GAfAI3jeEKSjUe iIxpu3XPsZrmfOMJXs3i64k49fYGogDsC4BpmYqtQs1t3/yCiJprMX5XavMFuQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=ZB4Apa6B; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -3.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=ZB4Apa6B; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 7ADE9177C0 X-Spam-Score: -3.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: Hw1ffY5xCZdi --=-2VIjVyZrhFZYcegwHDxm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Vagrant Cascadian schreef op do 22-04-2021 om 10:57 [-0700]: > On 2021-04-22, Maxime Devos wrote: > > + (define (check-pluralized-this-package description) > > + "Check that DESCRIPTION does not contain This packages" > >=20 > > The sentence structure would be clearer if you used quotes here, > > something like "Check that DESCRIPTION does not contain =E2=80=98This p= ackages=E2=80=99". >=20 > Any compelling reason to use =E2=80=98This packages=E2=80=99 vs. 'This pa= ckages' ? I find =E2=80=98curly quotes=E2=80=99 more aesthetically pleasing, though t= hat's a bit subjective I guess. > It seems other quotes in guix/lint.scm use '' also, I believe they should use =E2=80=98curly quotes=E2=80=99 as well, though I = would like to hear what other things about that first. > and I'm not apparently > skilled enough with a keyboard to generate =E2=80=98=E2=80=99-style quote= s... :) If your keyboard is azerty, you could choose =E2=80=98Belgian alternative= =E2=80=99, and type =E2=80=98 with alt-gr+f and =E2=80=99 with alt-gr+g. > Updated the commit message and incorporated the above suggestions into > the updated attached patch. One other suggestion: you used "string-match" in 'check-pluralized-this-pac= kage', which is a bit overkill. string-match interprets its first argument as a r= egex. The procedure "string-contains" is simpler and probably more efficient. The patch looks good otherwise. Greetings, Maxime. --=-2VIjVyZrhFZYcegwHDxm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYIG64hccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7s1SAP49qSu0Cb+lpiG9d3u/bp6jldfK 1bFVLabTd1mjvILUgQD+OQQL38Y3qweGxWKqGg2njcvMGu3cDi3mQTz/GkXxzw0= =/QsW -----END PGP SIGNATURE----- --=-2VIjVyZrhFZYcegwHDxm--