unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Jack Hill <jackhill@jackhill.us>
Cc: 41174@debbugs.gnu.org
Subject: bug#41174: [PATCH] gnu: webkitgtk: Add patch to share all fonts.
Date: Tue, 26 May 2020 23:56:18 +0200	[thread overview]
Message-ID: <1b9e299efed71d54ee14fbe904647553864bdc73.camel@student.tugraz.at> (raw)
In-Reply-To: <alpine.DEB.2.20.2005261546210.5735@marsh.hcoop.net>

Am Dienstag, den 26.05.2020, 15:47 -0400 schrieb Jack Hill:
> On Tue, 26 May 2020, Leo Prikler wrote:
> 
> > * gnu/packages/patches/webkitgtk-bind-all-fonts.patch: New file.
> > * gnu/packages/webkit.scm (webkitgtk)[source]<patches>: Use it
> > here.
> > * gnu/local.mk: Add it here.
> > ---
> > gnu/local.mk                                  |  1 +
> > .../patches/webkitgtk-bind-all-fonts.patch    | 37
> > +++++++++++++++++++
> > gnu/packages/webkit.scm                       |  3 +-
> > 3 files changed, 40 insertions(+), 1 deletion(-)
> > create mode 100644 gnu/packages/patches/webkitgtk-bind-all-
> > fonts.patch
> 
> Hi,
> 
> I tested this patch on my local system, and it seems to resolve the
> issue 
> for me. Thanks!
> 
> Is this something that should be submitted for inclusion in WebKit 
> upstream?
> 
> Best,
> Jack
Hi, 

I don't see anything in the patch itself, that is specific to Guix, so
it should probably work upstream as well.  This issue is likely going
to affect other functional package managers like Nix too, so it would
be nice, if we can get the patch to be accepted upstream.  However, it
does add a specific exception just for fonts, while other resources are
still taken from XDG_DATA_HOME.  As such, it is still rather an ad-hoc
solution to a very specific annoyance than something "general".

I'm also not quite sure, whether this could cause problems with the
number of arguments being passed to the bwrap process exceeding some
limit.  It has not yet come up so far, but I thought I'd mention it. 
However, if it does, we're going to be the first to notice with our
huge environment variables, so that's probably a bigger deal here than
elsewhere.

Regards,
Leo





  reply	other threads:[~2020-05-26 21:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 13:02 bug#41174: Epiphany can't find fonts Leo Prikler
     [not found] ` <handler.41174.B.158911578424933.ack@debbugs.gnu.org>
2020-05-18  0:27   ` Leo Prikler
2020-05-26 18:13 ` bug#41174: [PATCH] gnu: webkitgtk: Add patch to share all fonts Leo Prikler
2020-05-26 19:47   ` Jack Hill
2020-05-26 21:56     ` Leo Prikler [this message]
2020-05-27  1:18       ` Jack Hill
2020-08-16 20:19   ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b9e299efed71d54ee14fbe904647553864bdc73.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=41174@debbugs.gnu.org \
    --cc=jackhill@jackhill.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).