From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yBvWGLaQzV5vOQAA0tVLHw (envelope-from ) for ; Tue, 26 May 2020 21:57:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yPCMFLaQzV6tdwAA1q6Kng (envelope-from ) for ; Tue, 26 May 2020 21:57:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 00E0E940B2B for ; Tue, 26 May 2020 21:57:10 +0000 (UTC) Received: from localhost ([::1]:33890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdhZM-0005ou-Vk for larch@yhetil.org; Tue, 26 May 2020 17:57:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdhZG-0005om-7B for bug-guix@gnu.org; Tue, 26 May 2020 17:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdhZF-00035o-UH for bug-guix@gnu.org; Tue, 26 May 2020 17:57:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdhZF-0006SK-UT for bug-guix@gnu.org; Tue, 26 May 2020 17:57:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41174: [PATCH] gnu: webkitgtk: Add patch to share all fonts. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 26 May 2020 21:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41174 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jack Hill Received: via spool by 41174-submit@debbugs.gnu.org id=B41174.159053019424777 (code B ref 41174); Tue, 26 May 2020 21:57:01 +0000 Received: (at 41174) by debbugs.gnu.org; 26 May 2020 21:56:34 +0000 Received: from localhost ([127.0.0.1]:46817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdhYk-0006RT-2y for submit@debbugs.gnu.org; Tue, 26 May 2020 17:56:34 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:53570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdhYe-0006RF-EP for 41174@debbugs.gnu.org; Tue, 26 May 2020 17:56:29 -0400 Received: from nijino.local (194-96-185-81.hdsl.highway.telekom.at [194.96.185.81]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 49Wnpr2ZxGz1LWny; Tue, 26 May 2020 23:56:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 49Wnpr2ZxGz1LWny DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1590530180; bh=SECvJs6WmC9c2zRBuk7CHHwSO9BOqLEXHAX/teyT1Z8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=RUojeDdOis8onSzilWEOFcvfAbPQ/eVjT/62XNWMRfNl4upLsABYF/Dz+CvGj/it/ hF69hpXI3fN47q+q4RHU9z8m2BsieEu5nGlLXN1P8SG5zdLTLpMT5ghbfkWJ7IFywd 0Wbpe845805+JKPRqOvIPbYDU3Unu3fpA/zl6Ax8= Message-ID: <1b9e299efed71d54ee14fbe904647553864bdc73.camel@student.tugraz.at> From: Leo Prikler Date: Tue, 26 May 2020 23:56:18 +0200 In-Reply-To: References: <20200526181345.32726-1-leo.prikler@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41174@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=RUojeDdO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: W4lM4pABVR73 Am Dienstag, den 26.05.2020, 15:47 -0400 schrieb Jack Hill: > On Tue, 26 May 2020, Leo Prikler wrote: > > > * gnu/packages/patches/webkitgtk-bind-all-fonts.patch: New file. > > * gnu/packages/webkit.scm (webkitgtk)[source]: Use it > > here. > > * gnu/local.mk: Add it here. > > --- > > gnu/local.mk | 1 + > > .../patches/webkitgtk-bind-all-fonts.patch | 37 > > +++++++++++++++++++ > > gnu/packages/webkit.scm | 3 +- > > 3 files changed, 40 insertions(+), 1 deletion(-) > > create mode 100644 gnu/packages/patches/webkitgtk-bind-all- > > fonts.patch > > Hi, > > I tested this patch on my local system, and it seems to resolve the > issue > for me. Thanks! > > Is this something that should be submitted for inclusion in WebKit > upstream? > > Best, > Jack Hi, I don't see anything in the patch itself, that is specific to Guix, so it should probably work upstream as well. This issue is likely going to affect other functional package managers like Nix too, so it would be nice, if we can get the patch to be accepted upstream. However, it does add a specific exception just for fonts, while other resources are still taken from XDG_DATA_HOME. As such, it is still rather an ad-hoc solution to a very specific annoyance than something "general". I'm also not quite sure, whether this could cause problems with the number of arguments being passed to the bwrap process exceeding some limit. It has not yet come up so far, but I thought I'd mention it. However, if it does, we're going to be the first to notice with our huge environment variables, so that's probably a bigger deal here than elsewhere. Regards, Leo