* bug#53790: Audacity has extraneous binary at directory root
@ 2022-02-04 22:03 Leo Famulari
2022-02-05 7:22 ` Liliana Marie Prikler
0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2022-02-04 22:03 UTC (permalink / raw)
To: 53790
Our Audacity package creates an extraneous "audacity" binary in the root
of the store item:
------
$ git describe
v1.3.0-15695-gba60aede97
$ ls -la $(./pre-inst-env guix build audacity)
total 49012
dr-xr-xr-x 6 root root 4096 Dec 31 1969 .
drwxrwxr-t 3440 root guixbuild 50139136 Feb 4 17:00 ..
-r-xr-xr-x 1 root root 337 Dec 31 1969 audacity
dr-xr-xr-x 2 root root 4096 Dec 31 1969 bin
dr-xr-xr-x 2 root root 4096 Dec 31 1969 etc
dr-xr-xr-x 3 root root 4096 Dec 31 1969 lib
dr-xr-xr-x 11 root root 4096 Dec 31 1969 share
$ ls -la $(./pre-inst-env guix build audacity)/bin
total 18404
dr-xr-xr-x 2 root root 4096 Dec 31 1969 .
dr-xr-xr-x 6 root root 4096 Dec 31 1969 ..
-r-xr-xr-x 1 root root 600 Dec 31 1969 audacity
-r-xr-xr-x 2 root root 18827912 Dec 31 1969 .audacity-real
------
This didn't occur before the update from Audacity 2.4.2 to 3.1.3.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#53790: Audacity has extraneous binary at directory root
2022-02-04 22:03 bug#53790: Audacity has extraneous binary at directory root Leo Famulari
@ 2022-02-05 7:22 ` Liliana Marie Prikler
2022-02-05 18:52 ` Leo Famulari
0 siblings, 1 reply; 5+ messages in thread
From: Liliana Marie Prikler @ 2022-02-05 7:22 UTC (permalink / raw)
To: Leo Famulari, 53790
Hi Leo,
Am Freitag, dem 04.02.2022 um 17:03 -0500 schrieb Leo Famulari:
> Our Audacity package creates an extraneous "audacity" binary in the
> root of the store item:
>
> ------
> $ git describe
> v1.3.0-15695-gba60aede97
> $ ls -la $(./pre-inst-env guix build audacity)
> total 49012
> dr-xr-xr-x 6 root root 4096 Dec 31 1969 .
> drwxrwxr-t 3440 root guixbuild 50139136 Feb 4 17:00 ..
> -r-xr-xr-x 1 root root 337 Dec 31 1969 audacity
> dr-xr-xr-x 2 root root 4096 Dec 31 1969 bin
> dr-xr-xr-x 2 root root 4096 Dec 31 1969 etc
> dr-xr-xr-x 3 root root 4096 Dec 31 1969 lib
> dr-xr-xr-x 11 root root 4096 Dec 31 1969 share
> $ ls -la $(./pre-inst-env guix build audacity)/bin
> total 18404
> dr-xr-xr-x 2 root root 4096 Dec 31 1969 .
> dr-xr-xr-x 6 root root 4096 Dec 31 1969 ..
> -r-xr-xr-x 1 root root 600 Dec 31 1969 audacity
> -r-xr-xr-x 2 root root 18827912 Dec 31 1969 .audacity-real
> ------
Looking at the size of this thing compared to our audacity, I thought
to myself "hmm, that's a shell script" and sure enough
--8<---------------cut here---------------start------------->8---
#!/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/sh
lib="${0%/*}/lib/audacity"
share="${0%/*}/share/audacity"
export LD_LIBRARY_PATH="${lib}:${LD_LIBRARY_PATH}"
export AUDACITY_MODULES_PATH="${AUDACITY_MODULES_PATH}:${lib}/modules"
export AUDACITY_PATH="${AUDACITY_PATH}:${share}"
exec "${0%/*}/bin/audacity" "$@"
--8<---------------cut here---------------end--------------->8---
At the time of writing none of these appear particularly needed, though
if the time comes we might just port over the 'wrap-emacs-paths phase.
We can try searching for the bits in CMakeLists that install this
wrapper or we can simply drop the file. WDYT?
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#53790: Audacity has extraneous binary at directory root
2022-02-05 7:22 ` Liliana Marie Prikler
@ 2022-02-05 18:52 ` Leo Famulari
2022-02-05 22:52 ` Liliana Marie Prikler
2022-08-21 14:54 ` Liliana Marie Prikler
0 siblings, 2 replies; 5+ messages in thread
From: Leo Famulari @ 2022-02-05 18:52 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 53790
On Sat, Feb 05, 2022 at 08:22:32AM +0100, Liliana Marie Prikler wrote:
> Looking at the size of this thing compared to our audacity, I thought
> to myself "hmm, that's a shell script" and sure enough
>
> --8<---------------cut here---------------start------------->8---
> #!/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-5.1.8/bin/sh
>
> lib="${0%/*}/lib/audacity"
> share="${0%/*}/share/audacity"
>
> export LD_LIBRARY_PATH="${lib}:${LD_LIBRARY_PATH}"
> export AUDACITY_MODULES_PATH="${AUDACITY_MODULES_PATH}:${lib}/modules"
> export AUDACITY_PATH="${AUDACITY_PATH}:${share}"
>
> exec "${0%/*}/bin/audacity" "$@"
> --8<---------------cut here---------------end--------------->8---
Interesting...
> At the time of writing none of these appear particularly needed, though
> if the time comes we might just port over the 'wrap-emacs-paths phase.
I figure it's there for a reason. Maybe we just need to make sure it
ends up in 'bin/'? But, it's weird that the build scripts create multiple
executables with the same name in these different directories.
> We can try searching for the bits in CMakeLists that install this
> wrapper or we can simply drop the file. WDYT?
I don't know... I wonder if Audacity is worse for Guix users since this
shell script doesn't end up in $PATH.
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#53790: Audacity has extraneous binary at directory root
2022-02-05 18:52 ` Leo Famulari
@ 2022-02-05 22:52 ` Liliana Marie Prikler
2022-08-21 14:54 ` Liliana Marie Prikler
1 sibling, 0 replies; 5+ messages in thread
From: Liliana Marie Prikler @ 2022-02-05 22:52 UTC (permalink / raw)
To: Leo Famulari; +Cc: 53790
Hi,
Am Samstag, dem 05.02.2022 um 13:52 -0500 schrieb Leo Famulari:
> On Sat, Feb 05, 2022 at 08:22:32AM +0100, Liliana Marie Prikler
> wrote:
> > Looking at the size of this thing compared to our audacity, I
> > thought to myself "hmm, that's a shell script" and sure enough
> >
> > --8<---------------cut here---------------start------------->8---
> > #!/gnu/store/4y5m9lb8k3qkb1y9m02sw9w9a6hacd16-bash-minimal-
> > 5.1.8/bin/sh
> >
> > lib="${0%/*}/lib/audacity"
> > share="${0%/*}/share/audacity"
> >
> > export LD_LIBRARY_PATH="${lib}:${LD_LIBRARY_PATH}"
> > export
> > AUDACITY_MODULES_PATH="${AUDACITY_MODULES_PATH}:${lib}/modules"
> > export AUDACITY_PATH="${AUDACITY_PATH}:${share}"
> >
> > exec "${0%/*}/bin/audacity" "$@"
> > --8<---------------cut here---------------end--------------->8---
>
> Interesting...
>
> > At the time of writing none of these appear particularly needed,
> > though
> > if the time comes we might just port over the 'wrap-emacs-paths
> > phase.
>
> I figure it's there for a reason. Maybe we just need to make sure it
> ends up in 'bin/'? But, it's weird that the build scripts create
> multiple executables with the same name in these different
> directories.
I don't think it should be in bin/. Looking at the script, it appears
to be written for the install root, which... eh...
> > We can try searching for the bits in CMakeLists that install this
> > wrapper or we can simply drop the file. WDYT?
>
> I don't know... I wonder if Audacity is worse for Guix users since
> this shell script doesn't end up in $PATH.
Concerning LD_LIBRARY_PATH, that probably has no effect on Guix users.
AUDACITY_MODULES_PATH and AUDACITY_PATH could bug them, but only if run
through the store – I already added search-path specifications for
them. The question therefore really is whether to extend our wrapper or
not.
1. Cheers
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#53790: Audacity has extraneous binary at directory root
2022-02-05 18:52 ` Leo Famulari
2022-02-05 22:52 ` Liliana Marie Prikler
@ 2022-08-21 14:54 ` Liliana Marie Prikler
1 sibling, 0 replies; 5+ messages in thread
From: Liliana Marie Prikler @ 2022-08-21 14:54 UTC (permalink / raw)
To: Leo Famulari; +Cc: 53790-done
Am Samstag, dem 05.02.2022 um 13:52 -0500 schrieb Leo Famulari:
>
> > We can try searching for the bits in CMakeLists that install this
> > wrapper or we can simply drop the file. WDYT?
>
> I don't know... I wonder if Audacity is worse for Guix users since
> this shell script doesn't end up in $PATH.
After more than half a year without any complaint about our audacity
command, I doubt this. Thus I pushed a patch that removes the
gratuitous audacity.
Cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-21 14:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-04 22:03 bug#53790: Audacity has extraneous binary at directory root Leo Famulari
2022-02-05 7:22 ` Liliana Marie Prikler
2022-02-05 18:52 ` Leo Famulari
2022-02-05 22:52 ` Liliana Marie Prikler
2022-08-21 14:54 ` Liliana Marie Prikler
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).