unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Andy Wingo <wingo@igalia.com>, Guile Devel <guile-devel@gnu.org>
Subject: Re: [PATCH, v2] Fix build on ia64
Date: Sat, 8 Feb 2020 16:24:44 +0100	[thread overview]
Message-ID: <fb30f935-9d57-8e0e-6717-bd63d563aed2@physik.fu-berlin.de> (raw)
In-Reply-To: <87wo8xxj88.fsf@gnu.org>

Hi Ludo!

On 2/8/20 3:10 PM, Ludovic Courtès wrote:
> John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> skribis:
> 
>>   * libguile/continuations.c (capture_auxiliary_stack): Fix
>>     logic in preprocessor code when checking for ia64 host;
>>     fix dereferencing of ctx variable.
>>   * libguile/threads.h (struct scm_thread): Add missing member
>>     SCM_STACKITEM *auxiliary_stack_base.
> 
> Applied, thanks!  (I don’t have IA64 hardware to test it but it looks
> good to me and I trust it works for you on actual hardware.)

Thanks. Yes, both patches were tested on actual hardware running Debian
unstable. We are still maintaining unofficial Debian ports for both
architectures.

> BTW, these were simple changes and thus not requiring copyright
> assignment, but I would encourage you to assign copyright to the FSF for
> future changes if you plan to keep contributing (which would be great!).
> We can discuss the implications and paperwork off-list if you want.

I have actually signed the copyright assignment for the FSF already, but
only for gdb/binutils. I asked back then whether it would be possible to
sign the copyright assignment for all GNU projects but that was rejected.

I'll sign the CA next week for Guile.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



  reply	other threads:[~2020-02-08 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 13:14 [PATCH, v2] Fix build on ia64 John Paul Adrian Glaubitz
2020-02-08 14:10 ` Ludovic Courtès
2020-02-08 15:24   ` John Paul Adrian Glaubitz [this message]
2020-02-09 13:32     ` Ludovic Courtès
2020-02-09 23:00       ` Stefan Monnier
2020-03-04 17:09       ` John Paul Adrian Glaubitz
2020-03-05 16:21         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb30f935-9d57-8e0e-6717-bd63d563aed2@physik.fu-berlin.de \
    --to=glaubitz@physik.fu-berlin.de \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    --cc=wingo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).