From: "Ludovic Courtès" <ludo@gnu.org>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Andy Wingo <wingo@igalia.com>, Guile Devel <guile-devel@gnu.org>
Subject: Re: [PATCH, v2] Fix build on ia64
Date: Sat, 08 Feb 2020 15:10:47 +0100 [thread overview]
Message-ID: <87wo8xxj88.fsf@gnu.org> (raw)
In-Reply-To: <20200204131442.3348684-1-glaubitz@physik.fu-berlin.de> (John Paul Adrian Glaubitz's message of "Tue, 4 Feb 2020 14:14:43 +0100")
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> skribis:
> * libguile/continuations.c (capture_auxiliary_stack): Fix
> logic in preprocessor code when checking for ia64 host;
> fix dereferencing of ctx variable.
> * libguile/threads.h (struct scm_thread): Add missing member
> SCM_STACKITEM *auxiliary_stack_base.
Applied, thanks! (I don’t have IA64 hardware to test it but it looks
good to me and I trust it works for you on actual hardware.)
BTW, these were simple changes and thus not requiring copyright
assignment, but I would encourage you to assign copyright to the FSF for
future changes if you plan to keep contributing (which would be great!).
We can discuss the implications and paperwork off-list if you want.
Thank you!
Ludo’.
next prev parent reply other threads:[~2020-02-08 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 13:14 [PATCH, v2] Fix build on ia64 John Paul Adrian Glaubitz
2020-02-08 14:10 ` Ludovic Courtès [this message]
2020-02-08 15:24 ` John Paul Adrian Glaubitz
2020-02-09 13:32 ` Ludovic Courtès
2020-02-09 23:00 ` Stefan Monnier
2020-03-04 17:09 ` John Paul Adrian Glaubitz
2020-03-05 16:21 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo8xxj88.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=guile-devel@gnu.org \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).