From: "Thompson, David" <dthompson2@worcester.edu>
To: Jonas Hahnfeld <hahnjo@hahnjo.de>
Cc: "Mike Gran" <spk121@yahoo.com>,
"guile-devel@gnu.org" <guile-devel@gnu.org>,
"Ludovic Courtès" <ludo@gnu.org>, "Andy Wingo" <wingo@pobox.com>
Subject: Re: Guile 64-bit Windows support, redux
Date: Wed, 20 Mar 2024 16:40:20 -0400 [thread overview]
Message-ID: <CAJ=RwfZgTXts59QE2XZW3WCXH6XKXm-ssrCwRwTUBtGjqVwrPQ@mail.gmail.com> (raw)
In-Reply-To: <757086cd106c93d7db755fdff9165a04c39f9e97.camel@hahnjo.de>
On Wed, Mar 20, 2024 at 4:29 PM Jonas Hahnfeld <hahnjo@hahnjo.de> wrote:
>
> So I can confirm that JIT indeed doesn't work right now on 64-bit
> MinGW, but it's relatively easy to fix (first patch). In essence
> lightening was getting the calling convention wrong.
Wow! Have you seen the JIT do its thing (via GUILE_JIT_LOG) or just
verified that compilation succeeds when JIT is enabled? Either way, a
big step forward. The patch is very simple, too.
> Compilation just works --with-threads, as long as bdwgc was built with
> --enable-threads=posix to override the automatic detection of win32
> threading. I haven't tested if it actually works, but there might be a
> good chance.
This is also encouraging! Anyone out there want to run a test using
call-with-new-thread?
> For the one known issue I mentioned above, the fix is also not too
> difficult, just being a bit more careful with mixing scm_t_inum and
> long (see second patch).
The patch makes sense to me!
> I'm also explicitly CC'ing Andy and Ludo - we really need a statement
> by a maintainer whether this can land. From my point of view, it's a
> clear improvement in terms of supported platforms, plus tested by
> LilyPond since some time now which is probably one of the bigger
> "customers".
+1 on hearing from Andy and/or Ludo about this. Jonas' patches are
small and should be relatively quick to review. :)
If this stuff lands I will have to find a Windows machine to try it
out sometime.
Thanks Jonas!
- Dave
next prev parent reply other threads:[~2024-03-20 20:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1629803116.370682.1686084646758.ref@mail.yahoo.com>
2023-06-06 20:50 ` Guile 64-bit Windows support, redux Mike Gran
2023-06-06 20:56 ` Jean Abou Samra
2023-06-06 21:10 ` [EXT] " Thompson, David
2023-06-06 21:58 ` Mike Gran
2023-06-08 19:50 ` Maxime Devos
2023-06-08 20:46 ` Mike Gran
2023-06-09 11:01 ` Maxime Devos
2023-06-22 13:36 ` Mike Gran
2023-10-29 21:34 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2023-11-28 21:04 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2023-11-28 22:04 ` Dr. Arne Babenhauserheide
2024-01-04 10:40 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-02-06 6:44 ` Dr. Arne Babenhauserheide
2024-02-07 14:19 ` Thompson, David
2024-02-07 20:19 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-02-07 20:23 ` Thompson, David
2024-02-07 20:29 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-03-20 20:28 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-03-20 20:40 ` Thompson, David [this message]
2024-03-23 15:09 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-03-29 17:20 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfZgTXts59QE2XZW3WCXH6XKXm-ssrCwRwTUBtGjqVwrPQ@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guile-devel@gnu.org \
--cc=hahnjo@hahnjo.de \
--cc=ludo@gnu.org \
--cc=spk121@yahoo.com \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).