From: ludo@gnu.org (Ludovic Courtès)
To: Ian Hulin <ian@hulin.org.uk>
Cc: "lilypond-devel@gnu.org" <lilypond-devel@gnu.org>, guile-devel@gnu.org
Subject: Re: %module-public-interface
Date: Fri, 02 Apr 2010 11:37:41 +0200 [thread overview]
Message-ID: <87y6h6kxei.fsf@gnu.org> (raw)
In-Reply-To: <4BB53617.7060700@hulin.org.uk> (Ian Hulin's message of "Fri, 02 Apr 2010 01:11:03 +0100")
Hi Ian,
Ian Hulin <ian@hulin.org.uk> writes:
> On 30/03/10 22:52, Ludovic � wrote:
>> Andy Wingo<wingo@pobox.com> writes:
>>
>>> On Tue 30 Mar 2010 22:56, ludo@gnu.org (Ludovic Courtès) writes:
>>>
>>>>> I'm pretty sure that the submodule thing can be changed without any
>>>>> problem. But it seems that the %module-public-interface is used
>>>>> explicitly, at least by texmacs and lilypond.
>>>>
>>>> How do they use it?
>>>
>>> Linking to the evil empire:
>>>
>>> http://www.google.com/codesearch?hl=en&lr=&q=%25module-public-interface&sbtn=Search
>>> http://www.google.com/codesearch?hl=en&lr=&q=%25module-public-interface+lang%3Ac%2B%2B&sbtn=Search
>>
>> Lilypond does:
>>
>> --8<---------------cut here---------------start------------->8---
>> mod = scm_call_0 (maker);
>> scm_module_define (mod, ly_symbol2scm ("%module-public-interface"),
>> mod);
>> --8<---------------cut here---------------end--------------->8---
>>
>> Solution: do something like:
>>
>> --8<---------------cut here---------------start------------->8---
>> #ifdef HAVE_SCM_SET_MODULE_PUBLIC_INTERFACE_X
>> scm_set_module_public_interface_x (mod, mod);
>> #else
>> scm_module_define (mod, ly_symbol2scm ("%module-public-interface"),
>> mod);
>> #endif
>> --8<---------------cut here---------------end--------------->8---
>>
>> (We just need to add that function.)
>>
>
>> TeXmacs does:
> <snip>
>>>> And we could add a ‘public-interface’ slot to ‘module-type’ and have
>>>> ‘module-public-interface’ and ‘set-module-public-interface!’ refer to
>>>> it; for backward compatibility we’d also initialize the
>>>> ‘%module-public-interface’ binding. How does it sound?
>>
>> Actually the trick wouldn’t work in cases where the
>> ‘%module-public-interface’ binding is mutated, as with Lilypond.
>>
>> Given this and the above examples, I’d suggest dropping that binding
>> completely and sending patches to the Lilypond/TeXmacs people.
>>
>> What do you think?
>
> If you do add scm_set_module_public_interface_x, could you back-port
> it to Guile V1.8.6 and V1.8.7?
We could back-port it to the 1.8 series, but not to the already-released
1.8.7 and 1.8.6. We’d have to make a 1.8.8 release, but I’m not sure
that would really help anyway since that would force Lilypond users to
switch to that version.
> Those are the lowest versions of Guile the upcoming stable release of
> Lilypond will support.
How about doing #ifdef HAVE_SCM_SET_MODULE_PUBLIC_INTERFACE_X in your
code?
We still have to agree on the change and actually implement it, the
latter being easy. ;-) When is the new Lilypond release due?
Thanks,
Ludo’.
next prev parent reply other threads:[~2010-04-02 9:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 20:45 %module-public-interface Andy Wingo
2010-03-30 20:56 ` %module-public-interface Ludovic Courtès
2010-03-30 21:07 ` %module-public-interface Andy Wingo
2010-03-30 21:52 ` %module-public-interface Ludovic Courtès
2010-03-30 22:20 ` %module-public-interface Andy Wingo
2010-04-02 0:11 ` %module-public-interface Ian Hulin
2010-04-02 9:37 ` Ludovic Courtès [this message]
2010-04-02 11:58 ` %module-public-interface Ian Hulin
2010-04-02 18:50 ` %module-public-interface Patrick McCarty
2010-04-03 0:52 ` %module-public-interface Graham Percival
2010-04-06 14:00 ` %module-public-interface Han-Wen Nienhuys
2010-04-06 14:32 ` %module-public-interface Ludovic Courtès
2010-04-27 20:34 ` %module-public-interface Andy Wingo
2010-05-15 20:32 ` %module-public-interface Ian Hulin
2010-05-21 9:48 ` %module-public-interface Andy Wingo
2010-03-31 20:42 ` Hierarchical name space Ludovic Courtès
2010-03-31 22:31 ` Andy Wingo
2010-04-07 22:42 ` Julian Graham
2010-04-07 23:01 ` Ludovic Courtès
2010-04-08 7:29 ` Andy Wingo
2010-04-08 8:39 ` Ludovic Courtès
-- strict thread matches above, loose matches on Subject: below --
2020-01-15 6:50 %module-public-interface dsmich
2020-01-15 19:59 ` %module-public-interface Andy Wingo
2007-08-10 13:57 %module-public-interface Andy Wingo
2007-08-10 14:54 ` %module-public-interface Ludovic Courtès
2010-03-30 21:02 ` %module-public-interface Andy Wingo
2010-03-30 21:40 ` %module-public-interface Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6h6kxei.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guile-devel@gnu.org \
--cc=ian@hulin.org.uk \
--cc=lilypond-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).