[PATCH] getopt-long permits numbers for short options.

[PATCH] getopt-long permits numbers for short options.

[Marius Bakke]

* module/ice-9/getopt-long.scm (short-opt-rx): Add 0-9.
---
 module/ice-9/getopt-long.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/module/ice-9/getopt-long.scm b/module/ice-9/getopt-long.scm
index 18b235390..0077183da 100644
--- a/module/ice-9/getopt-long.scm
+++ b/module/ice-9/getopt-long.scm
@@ -221,7 +221,7 @@
 	  ((string=? "--" (car no)) (cons (reverse yes) (cdr no)))
 	  (else (loop (cons (car no) yes) (cdr no))))))
 
-(define short-opt-rx           (make-regexp "^-([a-zA-Z]+)(.*)"))
+(define short-opt-rx           (make-regexp "^-([a-zA-Z0-9]+)(.*)"))
 (define long-opt-no-value-rx   (make-regexp "^--([^=]+)$"))
 (define long-opt-with-value-rx (make-regexp "^--([^=]+)=(.*)"))
 
-- 
2.41.0

Re: [PATCH] getopt-long permits numbers for short options.

[Janneke Nieuwenhuizen]

Marius Bakke writes:

> * module/ice-9/getopt-long.scm (short-opt-rx): Add 0-9.

Hehe, reminds me of

    https://lists.gnu.org/archive/html/bug-guile/2018-07/msg00009.html

> diff --git a/module/ice-9/getopt-long.scm b/module/ice-9/getopt-long.scm
> index 18b235390..0077183da 100644
> --- a/module/ice-9/getopt-long.scm
> +++ b/module/ice-9/getopt-long.scm
> @@ -221,7 +221,7 @@
>  	  ((string=? "--" (car no)) (cons (reverse yes) (cdr no)))
>  	  (else (loop (cons (car no) yes) (cdr no))))))
>  
> -(define short-opt-rx           (make-regexp "^-([a-zA-Z]+)(.*)"))
> +(define short-opt-rx           (make-regexp "^-([a-zA-Z0-9]+)(.*)"))
>  (define long-opt-no-value-rx   (make-regexp "^--([^=]+)$"))
>  (define long-opt-with-value-rx (make-regexp "^--([^=]+)=(.*)"))

FWIW, LGTM :)

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

Re: [PATCH] getopt-long permits numbers for short options.

[Dale Mellor]

On Tue, 2023-09-05 at 08:25 +0200, Janneke Nieuwenhuizen wrote:
> Marius Bakke writes:
> 
> > * module/ice-9/getopt-long.scm (short-opt-rx): Add 0-9.
> 
> Hehe, reminds me of
> 
>    
> https://lists.gnu.org/archive/html/bug-guile/2018-07/msg00009.html
> 
> 

Also note https://debbugs.gnu.org/db/42/42669.html.  You see, your
solution fails if '-1' were supposed to be read literally as a
positional parameter.  The only solution is to make getopt-long more
intelligent in how it applies the pattern specification.

On the whole, both mine and Marius' patches are now years old and the
outstanding bug list is massive; these things are not going to get done
without a sea-change in the project administration.

Dale

Re: [PATCH] getopt-long permits numbers for short options.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

Janneke Nieuwenhuizen <janneke@gnu.org> skriver:

> Marius Bakke writes:
>
>> * module/ice-9/getopt-long.scm (short-opt-rx): Add 0-9.
>
> Hehe, reminds me of
>
>     https://lists.gnu.org/archive/html/bug-guile/2018-07/msg00009.html

Hey, time flies...  There is now:

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=42669

...which avoids the test failure mentioned in #32154.

(actually the tests do not fail, but merely prints UNRESOLVED, which I
missed due to exit code 0 ... that seems like a bug, but anyway.)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]