From: Rob Browning <rlb@defaultvalue.org>
To: guile-devel@gnu.org
Subject: Re: [PATCH 1/1] (scheme base) member: return #f, not (), for no match
Date: Sun, 04 Oct 2020 13:59:59 -0500 [thread overview]
Message-ID: <87mu11stow.fsf@trouble.defaultvalue.org> (raw)
In-Reply-To: <87h7raue0j.fsf@trouble.defaultvalue.org>
Rob Browning <rlb@defaultvalue.org> writes:
> Hmm, this causes a failure in r7rs.test. Not sure if I made a mistake,
> or if other code depends on the incorrect behavior. Looking in to it.
Ahh, it just revealed a bug in r7rs.test, i.e.:
diff --git a/test-suite/tests/r7rs.test b/test-suite/tests/r7rs.test
index 0914f0c5e..1cc8cd31e 100644
--- a/test-suite/tests/r7rs.test
+++ b/test-suite/tests/r7rs.test
@@ -2171,7 +2171,7 @@
(let ((out (open-output-string))
(x (list 1)))
(set-cdr! x x)
- (write x out)
+ (write-shared x out)
(get-output-string out))
;; labels not guaranteed to be 0 indexed, spacing may differ
'("#0=(1 . #0#)" "#1=(1 . #1#)"))
I'll add that to the commit.
--
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4
prev parent reply other threads:[~2020-10-04 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 15:50 [PATCH 1/1] (scheme base) member: return #f, not (), for no match Rob Browning
2020-10-04 16:55 ` Rob Browning
2020-10-04 18:59 ` Rob Browning [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu11stow.fsf@trouble.defaultvalue.org \
--to=rlb@defaultvalue.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).