From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rob Browning Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH 1/1] (scheme base) member: return #f, not (), for no match Date: Sun, 04 Oct 2020 13:59:59 -0500 Message-ID: <87mu11stow.fsf@trouble.defaultvalue.org> References: <20201004155009.184217-1-rlb@defaultvalue.org> <87h7raue0j.fsf@trouble.defaultvalue.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11204"; mail-complaints-to="usenet@ciao.gmane.io" To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Sun Oct 04 21:00:49 2020 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP9FT-0002kG-2H for guile-devel@m.gmane-mx.org; Sun, 04 Oct 2020 21:00:43 +0200 Original-Received: from localhost ([::1]:36866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kP9FS-00026l-41 for guile-devel@m.gmane-mx.org; Sun, 04 Oct 2020 15:00:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kP9Er-00024h-ID for guile-devel@gnu.org; Sun, 04 Oct 2020 15:00:05 -0400 Original-Received: from defaultvalue.org ([45.33.119.55]:38460) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kP9Ep-0005zz-St for guile-devel@gnu.org; Sun, 04 Oct 2020 15:00:05 -0400 Original-Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 555EE20237 for ; Sun, 4 Oct 2020 14:00:00 -0500 (CDT) Original-Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id D990614E072; Sun, 4 Oct 2020 13:59:59 -0500 (CDT) In-Reply-To: <87h7raue0j.fsf@trouble.defaultvalue.org> Received-SPF: pass client-ip=45.33.119.55; envelope-from=rlb@defaultvalue.org; helo=defaultvalue.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/04 15:00:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20590 Archived-At: Rob Browning writes: > Hmm, this causes a failure in r7rs.test. Not sure if I made a mistake, > or if other code depends on the incorrect behavior. Looking in to it. Ahh, it just revealed a bug in r7rs.test, i.e.: diff --git a/test-suite/tests/r7rs.test b/test-suite/tests/r7rs.test index 0914f0c5e..1cc8cd31e 100644 --- a/test-suite/tests/r7rs.test +++ b/test-suite/tests/r7rs.test @@ -2171,7 +2171,7 @@ (let ((out (open-output-string)) (x (list 1))) (set-cdr! x x) - (write x out) + (write-shared x out) (get-output-string out)) ;; labels not guaranteed to be 0 indexed, spacing may differ '("#0=(1 . #0#)" "#1=(1 . #1#)")) I'll add that to the commit. -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4