From: "Ludovic Courtès" <ludo@gnu.org>
To: Greg Troxel <gdt@lexort.com>
Cc: "guile-devel@gnu.org" <guile-devel@gnu.org>
Subject: Re: GNU Guile 3.0.9rc1 available for testing!
Date: Wed, 25 Jan 2023 11:32:06 +0100 [thread overview]
Message-ID: <87cz72vra1.fsf@gnu.org> (raw)
In-Reply-To: <rmiv8kv75i4.fsf@s1.lexort.com> (Greg Troxel's message of "Tue, 24 Jan 2023 20:44:03 -0500")
[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]
Hi Greg,
Greg Troxel <gdt@lexort.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> So something like the patch below?
>>
>> Thanks,
>> Ludo’.
>>
>> diff --git a/libguile/posix.c b/libguile/posix.c
>> index 74c743119..0b1fe2637 100644
>> --- a/libguile/posix.c
>> +++ b/libguile/posix.c
>> @@ -105,8 +105,8 @@
>> # else
>> # define W_EXITCODE(ret, sig) ((ret) << 8 | (sig))
>> # endif
>> -#endif
>> verify (WEXITSTATUS (W_EXITCODE (127, 0)) == 127);
>> +#endif
>>
>>
>> #include <signal.h>
>
> I see you pushed that to master and I have done a full build from master
> with the pkgsrc JIT workarounds. It mostly worked and I got this, which
> may be because I purged not-needed packages (but the guile build didn't
> complain at configure or check time, like it did for missing gperf which
> I put back). Or maybe I just haven't gotten this far with 3.0.9-ish.
>
> CC test_foreign_object_c-test-foreign-object-c.o
> CCLD test-foreign-object-c
> ld: ../../libguile/.libs/libguile-3.0.so: warning: warning: tmpnam() possibly used unsafely, use mkstemp() or mkdtemp()
> ld: /tmp//ccOnwVqC.ltrans0.ltrans.o: in function `finalizer':
> /home/n0/gdt/SOFTWARE/GUILE/guile/BUILD/test-suite/standalone/../../../test-suite/standalone/test-foreign-object-c.c:42: undefined reference to `rpl_free'
I believe this is because these C files in test-suite/standalone end up
including Gnulib headers (like <stdlib.h>), which really shouldn’t be
necessary, without linking against libgnu.a.
I believe the patch below fixes that.
[...]
> There are some issues for me to work through eventually, but for 3.0.9 I
> have arrived at being ok with you releasing the current state of git
> master (3 commits past rc1) as not having anything I can claim is a
> regression and not anything I can't work around as before.
Sounds good.
Thanks for your feedback!
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1205 bytes --]
diff --git a/test-suite/standalone/Makefile.am b/test-suite/standalone/Makefile.am
index 547241afa..0b5d05ddb 100644
--- a/test-suite/standalone/Makefile.am
+++ b/test-suite/standalone/Makefile.am
@@ -1,7 +1,7 @@
## Process this file with automake to produce Makefile.in.
##
## Copyright 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010,
-## 2011, 2012, 2013, 2014, 2020, 2021, 2022 Free Software Foundation, Inc.
+## 2011, 2012, 2013, 2014, 2020, 2021, 2022, 2023 Free Software Foundation, Inc.
##
## This file is part of GUILE.
##
@@ -39,8 +39,7 @@ TESTS_ENVIRONMENT = \
## Check for headers in $(srcdir) and build dir before $(CPPFLAGS), which
## may point us to an old, installed version of guile.
-AM_CPPFLAGS = -I$(top_srcdir) -I$(top_builddir) \
- -I$(top_srcdir)/lib -I$(top_builddir)/lib
+AM_CPPFLAGS = -I$(top_srcdir) -I$(top_builddir)
test_cflags = \
-I$(top_srcdir)/test-suite/standalone -I. \
@@ -55,7 +54,7 @@ LIBGUILE_LDADD = \
snarfcppopts = \
- -I$(top_srcdir) -I$(top_srcdir)/lib -I$(top_builddir)/lib -I$(top_builddir) \
+ -I$(top_srcdir) -I$(top_builddir) \
-I. $(DEFS) $(DEFAULT_INCLUDES) $(CPPFLAGS) $(CFLAGS)
SUFFIXES = .x
next prev parent reply other threads:[~2023-01-25 10:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 15:58 GNU Guile 3.0.9rc1 available for testing! Ludovic Courtès
2023-01-20 16:18 ` Thompson, David
2023-01-21 14:58 ` Jan Nieuwenhuizen
2023-01-23 10:42 ` Ludovic Courtès
2023-01-23 13:23 ` Janneke Nieuwenhuizen
2023-01-20 17:50 ` Aleix Conchillo Flaqué
2023-01-23 10:45 ` Ludovic Courtès
2023-01-23 17:01 ` Aleix Conchillo Flaqué
2023-01-22 2:12 ` Greg Troxel
2023-01-22 14:30 ` lloda
2023-01-22 14:39 ` Greg Troxel
2023-01-23 10:48 ` Ludovic Courtès
2023-01-23 18:04 ` lloda
2023-01-23 21:59 ` bug#60971: build failure of v3.0.9rc1 on mac os 12.6 Ludovic Courtès
2023-01-23 18:47 ` GNU Guile 3.0.9rc1 available for testing! Aleix Conchillo Flaqué
2023-01-25 1:44 ` Greg Troxel
2023-01-25 10:32 ` Ludovic Courtès [this message]
2023-01-22 17:41 ` Greg Troxel
2023-01-22 23:10 ` Greg Troxel
2023-01-23 11:02 ` Ludovic Courtès
2023-01-23 11:19 ` Ludovic Courtès
2023-01-24 15:43 ` Greg Troxel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz72vra1.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=gdt@lexort.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).