From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Newsgroups: gmane.lisp.guile.devel Subject: Re: GNU Guile 3.0.9rc1 available for testing! Date: Wed, 25 Jan 2023 11:32:06 +0100 Message-ID: <87cz72vra1.fsf@gnu.org> References: <87v8l15hb2.fsf@inria.fr> <562CD6BE-42D3-4D4C-AB4C-2B4A5341F525@sarc.name> <87h6wh34t0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37517"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: "guile-devel@gnu.org" To: Greg Troxel Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed Jan 25 11:32:54 2023 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKd5I-0009V8-IJ for guile-devel@m.gmane-mx.org; Wed, 25 Jan 2023 11:32:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKd4q-0005i3-BD; Wed, 25 Jan 2023 05:32:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKd4j-0005ee-IT for guile-devel@gnu.org; Wed, 25 Jan 2023 05:32:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKd4j-0007f9-09; Wed, 25 Jan 2023 05:32:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=y3YOfdazsNHKHLQUl6CABvNXc+WaIQfOAXm0iBckcNc=; b=LBLu07Sp/KHOriYi4fTg BxLt3zfrzdoJHBsvVye67grB8ad0MEW1KlqjHEW7Rbhiyyktgsjjqc64fEWZnyWQ784CiQwca5X/y 5vfVcA1/hRLc90J+qNhnc97BH97gPJxondIMIt3JTSfOWsp+uFSUxrts6pGjSqCxC8a4bqCrKKkEF qsK9LRr9kPNxmir0RBR10003mGRQLnqhLeHJSvzgjrP87nW95at2yV2IZikCbEeAKWJNEM1W3Ct0S eelCxpRFmW0EfxYsvJueB4RAxYTbdRa34HeKuJPIz0u98jtd5q40iKFx7zhSeqhN1lk1iUP9LtN3e wCscJjmy5vy4fQ==; Original-Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKd4a-0006vL-He; Wed, 25 Jan 2023 05:32:16 -0500 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 6 =?utf-8?Q?Pluvi=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Laurier-thym X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu In-Reply-To: (Greg Troxel's message of "Tue, 24 Jan 2023 20:44:03 -0500") X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:21629 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Greg, Greg Troxel skribis: > Ludovic Court=C3=A8s writes: > >> So something like the patch below? >> >> Thanks, >> Ludo=E2=80=99. >> >> diff --git a/libguile/posix.c b/libguile/posix.c >> index 74c743119..0b1fe2637 100644 >> --- a/libguile/posix.c >> +++ b/libguile/posix.c >> @@ -105,8 +105,8 @@ >> # else >> # define W_EXITCODE(ret, sig) ((ret) << 8 | (sig)) >> # endif >> -#endif >> verify (WEXITSTATUS (W_EXITCODE (127, 0)) =3D=3D 127); >> +#endif >>=20=20 >>=20=20 >> #include > > I see you pushed that to master and I have done a full build from master > with the pkgsrc JIT workarounds. It mostly worked and I got this, which > may be because I purged not-needed packages (but the guile build didn't > complain at configure or check time, like it did for missing gperf which > I put back). Or maybe I just haven't gotten this far with 3.0.9-ish. > > CC test_foreign_object_c-test-foreign-object-c.o > CCLD test-foreign-object-c > ld: ../../libguile/.libs/libguile-3.0.so: warning: warning: tmpnam() po= ssibly used unsafely, use mkstemp() or mkdtemp() > ld: /tmp//ccOnwVqC.ltrans0.ltrans.o: in function `finalizer': > /home/n0/gdt/SOFTWARE/GUILE/guile/BUILD/test-suite/standalone/../../../= test-suite/standalone/test-foreign-object-c.c:42: undefined reference to `r= pl_free' I believe this is because these C files in test-suite/standalone end up including Gnulib headers (like ), which really shouldn=E2=80=99t = be necessary, without linking against libgnu.a. I believe the patch below fixes that. [...] > There are some issues for me to work through eventually, but for 3.0.9 I > have arrived at being ok with you releasing the current state of git > master (3 commits past rc1) as not having anything I can claim is a > regression and not anything I can't work around as before. Sounds good. Thanks for your feedback! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/test-suite/standalone/Makefile.am b/test-suite/standalone/Makefile.am index 547241afa..0b5d05ddb 100644 --- a/test-suite/standalone/Makefile.am +++ b/test-suite/standalone/Makefile.am @@ -1,7 +1,7 @@ ## Process this file with automake to produce Makefile.in. ## ## Copyright 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, -## 2011, 2012, 2013, 2014, 2020, 2021, 2022 Free Software Foundation, Inc. +## 2011, 2012, 2013, 2014, 2020, 2021, 2022, 2023 Free Software Foundation, Inc. ## ## This file is part of GUILE. ## @@ -39,8 +39,7 @@ TESTS_ENVIRONMENT = \ ## Check for headers in $(srcdir) and build dir before $(CPPFLAGS), which ## may point us to an old, installed version of guile. -AM_CPPFLAGS = -I$(top_srcdir) -I$(top_builddir) \ - -I$(top_srcdir)/lib -I$(top_builddir)/lib +AM_CPPFLAGS = -I$(top_srcdir) -I$(top_builddir) test_cflags = \ -I$(top_srcdir)/test-suite/standalone -I. \ @@ -55,7 +54,7 @@ LIBGUILE_LDADD = \ snarfcppopts = \ - -I$(top_srcdir) -I$(top_srcdir)/lib -I$(top_builddir)/lib -I$(top_builddir) \ + -I$(top_srcdir) -I$(top_builddir) \ -I. $(DEFS) $(DEFAULT_INCLUDES) $(CPPFLAGS) $(CFLAGS) SUFFIXES = .x --=-=-=--