From: ludo@gnu.org (Ludovic Courtès)
To: Doug Evans <xdje42@gmail.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] Recognize '\r' for line buffering purposes
Date: Wed, 21 May 2014 15:36:42 +0200 [thread overview]
Message-ID: <87bnurnthx.fsf@gnu.org> (raw)
In-Reply-To: <CAP9bCMRvEUk6ARte5FHU8GSEwJfbKK4RbUxUdFBCu4uHPKG5OQ@mail.gmail.com> (Doug Evans's message of "Sat, 17 May 2014 12:27:43 -0700")
Doug Evans <xdje42@gmail.com> skribis:
> On Fri, May 16, 2014 at 2:39 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>> WDYT?
>>
>> I’ll push it shortly if there are no objections.
>>
>> Ludo’.
>
> Hi.
> For reference sake, I checked glibc and it only checks '\n' (AFAICT).
> ref: libio/fileops.c
Indeed.
It seems best to stick with libc’s behavior, so I ended up leaving
_IOLBF behavior unchanged (and I realized that the use case I was
interested in could be addressed differently anyway.) I pushed a test
case for _IOLBF since I realized we didn’t have any.
Thanks for your feedback!
Ludo’.
prev parent reply other threads:[~2014-05-21 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 9:39 [PATCH] Recognize '\r' for line buffering purposes Ludovic Courtès
2014-05-17 19:27 ` Doug Evans
2014-05-21 13:36 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnurnthx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guile-devel@gnu.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).