From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Recognize '\r' for line buffering purposes Date: Wed, 21 May 2014 15:36:42 +0200 Message-ID: <87bnurnthx.fsf@gnu.org> References: <87r43udpus.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1400679468 31657 80.91.229.3 (21 May 2014 13:37:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 May 2014 13:37:48 +0000 (UTC) Cc: guile-devel To: Doug Evans Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed May 21 15:37:41 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wn6iC-0000zg-Vk for guile-devel@m.gmane.org; Wed, 21 May 2014 15:37:41 +0200 Original-Received: from localhost ([::1]:59767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn6iC-000256-Jq for guile-devel@m.gmane.org; Wed, 21 May 2014 09:37:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn6hO-0001Hj-IT for guile-devel@gnu.org; Wed, 21 May 2014 09:36:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wn6hJ-0002tX-4o for guile-devel@gnu.org; Wed, 21 May 2014 09:36:50 -0400 Original-Received: from hera.aquilenet.fr ([2a01:474::1]:33156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wn6hI-0002sj-TD for guile-devel@gnu.org; Wed, 21 May 2014 09:36:45 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 5F6922A25; Wed, 21 May 2014 15:36:43 +0200 (CEST) Original-Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wuTk7GNjbQsW; Wed, 21 May 2014 15:36:43 +0200 (CEST) Original-Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0BA0B1D6; Wed, 21 May 2014 15:36:42 +0200 (CEST) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Prairial an 222 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: (Doug Evans's message of "Sat, 17 May 2014 12:27:43 -0700") User-Agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:474::1 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17152 Archived-At: Doug Evans skribis: > On Fri, May 16, 2014 at 2:39 AM, Ludovic Court=C3=A8s wrot= e: >> WDYT? >> >> I=E2=80=99ll push it shortly if there are no objections. >> >> Ludo=E2=80=99. > > Hi. > For reference sake, I checked glibc and it only checks '\n' (AFAICT). > ref: libio/fileops.c Indeed. It seems best to stick with libc=E2=80=99s behavior, so I ended up leaving _IOLBF behavior unchanged (and I realized that the use case I was interested in could be addressed differently anyway.) I pushed a test case for _IOLBF since I realized we didn=E2=80=99t have any. Thanks for your feedback! Ludo=E2=80=99.