From: Timothy Sample <samplet@ngyro.com>
To: Peter Elliott <pelliott@ualberta.ca>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] fix incorrect documentation for coverage-data->lcov
Date: Wed, 28 Aug 2019 16:42:11 -0400 [thread overview]
Message-ID: <877e6x81jw.fsf@ngyro.com> (raw)
In-Reply-To: <CAM7JtP1NUGzdGtLL6F068SFXKO02bTs11mvN=TJY6AdBJes6MA@mail.gmail.com> (Peter Elliott's message of "Tue, 27 Aug 2019 20:42:48 -0700")
Hi Peter,
Peter Elliott <pelliott@ualberta.ca> writes:
> Hello,
> coverage-data->lcov does not, and never has taken a 'modules'
> argument, so I've removed it.
> However, I would really like this, and might add it if it's not too hard.
I submitted a patch for this a little while ago:
https://lists.gnu.org/archive/html/guile-devel/2017-12/msg00006.html
My knowledge of the Guile internals was and is pretty limited, but the
patch worked for my purposes. Maybe it would be useful to you, too.
The only part that is weird in my patch (in retrospect) is that the
“modules” parameter is a list of filenames. The name doesn’t really
make the parameter type clear (it could be a list of modules objects or
a list of modules like you pass to “use-modules”).
I used it by filtering the results of “instrumented-source-files”:
(let ((modules (filter project-file?
(instrumented-source-files data))))
(coverage-data->lcov data port #:modules modules))
where “project-file?” tests if a file is part of the current project (as
opposed to part of Guile or another library).
Hope that helps!
-- Tim
prev parent reply other threads:[~2019-08-28 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 3:42 [PATCH] fix incorrect documentation for coverage-data->lcov Peter Elliott
2019-08-28 20:42 ` Timothy Sample [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e6x81jw.fsf@ngyro.com \
--to=samplet@ngyro.com \
--cc=guile-devel@gnu.org \
--cc=pelliott@ualberta.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).