From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Timothy Sample Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] fix incorrect documentation for coverage-data->lcov Date: Wed, 28 Aug 2019 16:42:11 -0400 Message-ID: <877e6x81jw.fsf@ngyro.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161368"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: guile-devel@gnu.org To: Peter Elliott Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Aug 29 01:43:20 2019 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i37ax-000fpD-SR for guile-devel@m.gmane.org; Thu, 29 Aug 2019 01:43:19 +0200 Original-Received: from localhost ([::1]:43764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i37aw-0007JL-Qz for guile-devel@m.gmane.org; Wed, 28 Aug 2019 19:43:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54340) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i34lk-0004Q0-CM for guile-devel@gnu.org; Wed, 28 Aug 2019 16:42:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i34lj-0002ti-4X for guile-devel@gnu.org; Wed, 28 Aug 2019 16:42:16 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57301) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i34li-0002t0-Pw for guile-devel@gnu.org; Wed, 28 Aug 2019 16:42:14 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EF5AB21EE9; Wed, 28 Aug 2019 16:42:12 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 28 Aug 2019 16:42:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=UlekMSQWxyBB88lR/FyUBeIIkAeBHAbsoBqa3RYT/ ZY=; b=TK4CifNdIgl1d3r7AY+Kzm5z9ulzNcQWBmZkXmIn/d/9QALnF1TOutqLz YzutCfmqm+kpThXxlmur3d0LpDhWAkIZykVIc8fFvftl6XRRXSbbS9ZezuPixRni JKixx5x3HCupMOXkyFB4N15wEAIX1S7rVcO0iLstygznOudK0d6kwi3xqSYhS4Ew 9R0WT0AK49g6wo4m8Gb0KcGv18C5ShC44C1/NK9bbdIbsbLekF1LkYYkBKTFZdEL 6IFLQvw8K9w+4K7DYwe8WFVslh1EduzTYSaZeYJFq/fYJy8sxcewU7U/nZGWL0TM bb9IDrOxLzZNQ4XAvcjgU2lUF49MA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudeitddgudehvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufhffjgfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhm ohhthhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucffoh hmrghinhepghhnuhdrohhrghenucfkphepjeegrdduudeirddukeeirdeggeenucfrrghr rghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtghomhenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Original-Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 5B67180065; Wed, 28 Aug 2019 16:42:12 -0400 (EDT) In-Reply-To: (Peter Elliott's message of "Tue, 27 Aug 2019 20:42:48 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.25 X-Mailman-Approved-At: Wed, 28 Aug 2019 19:43:14 -0400 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:20053 Archived-At: Hi Peter, Peter Elliott writes: > Hello, > coverage-data->lcov does not, and never has taken a 'modules' > argument, so I've removed it. > However, I would really like this, and might add it if it's not too hard. I submitted a patch for this a little while ago: https://lists.gnu.org/archive/html/guile-devel/2017-12/msg00006.html My knowledge of the Guile internals was and is pretty limited, but the patch worked for my purposes. Maybe it would be useful to you, too. The only part that is weird in my patch (in retrospect) is that the =E2=80=9Cmodules=E2=80=9D parameter is a list of filenames. The name doesn= =E2=80=99t really make the parameter type clear (it could be a list of modules objects or a list of modules like you pass to =E2=80=9Cuse-modules=E2=80=9D). I used it by filtering the results of =E2=80=9Cinstrumented-source-files=E2= =80=9D: (let ((modules (filter project-file? (instrumented-source-files data)))) (coverage-data->lcov data port #:modules modules)) where =E2=80=9Cproject-file?=E2=80=9D tests if a file is part of the curren= t project (as opposed to part of Guile or another library). Hope that helps! -- Tim