unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Jonas Hahnfeld <hahnjo@hahnjo.de>
Cc: guile-devel@gnu.org,  69315-done@debbugs.gnu.org
Subject: Re: bug#69315: [PATCH] Build system fixes
Date: Mon, 06 May 2024 11:37:13 +0200	[thread overview]
Message-ID: <874jbbmgc6.fsf@gnu.org> (raw)
In-Reply-To: <28cbafe86d959534413551b2fb3edec475e5be61.camel@hahnjo.de> (Jonas Hahnfeld's message of "Thu, 22 Feb 2024 22:14:04 +0100")

Hi Jonas,

Jonas Hahnfeld <hahnjo@hahnjo.de> skribis:

> From 428d1b17c5f664d3cb8da4cd5687bd47bdd87877 Mon Sep 17 00:00:00 2001
> From: Jonas Hahnfeld <hahnjo@hahnjo.de>
> Date: Thu, 22 Feb 2024 21:57:41 +0100
> Subject: [PATCH 1/2] build: Make sed invocation fully portable
>
> Commit 08041d216f attempted to make the "invocation compatible with
> BSD sed", but moving '-i' first does not solve the problem because
> it still requires to pass an argument. Instead just redirect the
> instantiated output into a temporary file and install that.
>
> * libguile/Makefile.am: Remove '-i' from INSTANTIATE.

[...]

> From ad01912391b449fcf547ac52ed468f9b572cb0ad Mon Sep 17 00:00:00 2001
> From: Jonas Hahnfeld <hahnjo@hahnjo.de>
> Date: Thu, 22 Feb 2024 22:10:06 +0100
> Subject: [PATCH 2/2] build: Fix cross-compilation in out-of-tree-builds
>
> gen-scmconfig.h is generated in libguile, not $(top_builddir).
>
> * libguile/Makefile.am: Add '-I.' when compiling gen-scmconfig.o.

Finally applied both, thanks!

Ludo’.



      parent reply	other threads:[~2024-05-06  9:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 21:14 [PATCH] Build system fixes Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-03-20 20:14 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-05-06  9:37 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jbbmgc6.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=69315-done@debbugs.gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=hahnjo@hahnjo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).