From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Newsgroups: gmane.lisp.guile.devel Subject: Re: bug#69315: [PATCH] Build system fixes Date: Mon, 06 May 2024 11:37:13 +0200 Message-ID: <874jbbmgc6.fsf@gnu.org> References: <28cbafe86d959534413551b2fb3edec475e5be61.camel@hahnjo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2887"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: guile-devel@gnu.org, 69315-done@debbugs.gnu.org To: Jonas Hahnfeld Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Mon May 06 11:37:27 2024 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3uml-0000as-Cr for guile-devel@m.gmane-mx.org; Mon, 06 May 2024 11:37:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3umc-0001qb-4Y; Mon, 06 May 2024 05:37:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3uma-0001q0-2Z for guile-devel@gnu.org; Mon, 06 May 2024 05:37:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3umZ-0007ue-QN; Mon, 06 May 2024 05:37:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=w0eiPrh17y1BpDzapEhuPdf9Dr3dLuUEpyb1pSsJZlE=; b=GieJ3SDEyciJFwYAgcK+ PWGlNwPwQ+H00bvoJVhCEvrqJWF2jmC6HvZTKAIhqy6N0oB/VOwCGTjvs1bkHf/6C8DLUjnZVUKct 5gp0rscJyXfvJN693/RpcfkDx/cSKr5SHB4RBDIvfb3gvORNXQOShagjqKdJZGwS7sKMuY4iZ9Mly BZrga/PUN9oeOUVnOHs18UvbJoQZuh2gBjUqG70zD6YQygbzUo4+hf2d8iFLzybivbcEVhQ2EMNu1 l1AEwAgx7sZ7XRsnNVbzHhce67t6Fs35K1qEW2zlLLRPyXns1P+BbK+xWEB3VM0dAdi5UKDMTWXKW 8rrOJTqCH3gQYA==; In-Reply-To: <28cbafe86d959534413551b2fb3edec475e5be61.camel@hahnjo.de> (Jonas Hahnfeld's message of "Thu, 22 Feb 2024 22:14:04 +0100") X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22412 Archived-At: Hi Jonas, Jonas Hahnfeld skribis: > From 428d1b17c5f664d3cb8da4cd5687bd47bdd87877 Mon Sep 17 00:00:00 2001 > From: Jonas Hahnfeld > Date: Thu, 22 Feb 2024 21:57:41 +0100 > Subject: [PATCH 1/2] build: Make sed invocation fully portable > > Commit 08041d216f attempted to make the "invocation compatible with > BSD sed", but moving '-i' first does not solve the problem because > it still requires to pass an argument. Instead just redirect the > instantiated output into a temporary file and install that. > > * libguile/Makefile.am: Remove '-i' from INSTANTIATE. [...] > From ad01912391b449fcf547ac52ed468f9b572cb0ad Mon Sep 17 00:00:00 2001 > From: Jonas Hahnfeld > Date: Thu, 22 Feb 2024 22:10:06 +0100 > Subject: [PATCH 2/2] build: Fix cross-compilation in out-of-tree-builds > > gen-scmconfig.h is generated in libguile, not $(top_builddir). > > * libguile/Makefile.am: Add '-I.' when compiling gen-scmconfig.o. Finally applied both, thanks! Ludo=E2=80=99.