[Hydra Build Daemon] [Guile-commits] Failed with output: Hydra job gnu:guile-2-0:build.x86_64-darwin

[Hydra Build Daemon] [Guile-commits] Failed with output: Hydra job gnu:guile-2-0:build.x86_64-darwin

[Mark H Weaver]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

Hi Ludovic,

The Darwin build was broken by 8f7887d61604073528544ccb09849ca0e2f4df78
"Provide glthread/lock.h implementation in terms of Guile threads".

I guess that we'll need to add some of the AM_CPPFLAGS from
libguile/Makefile.am to lib/Makefile.am.

We'll need to make sure not only that <glthread/lock.h> finds
<libguile/threads.h> from the source tree (not from previously-installed
Guile headers), but also that all of the Guile headers included directly
or indirectly from <libguile/threads.h> have access to the Gnulib
headers.

I confess to being a bit nervous about this circular dependency between
Guile and Gnulib.

What do you think?

      Mark



[-- Attachment #2: Type: message/rfc822, Size: 2359 bytes --]

From: Hydra Build Daemon <e.dolstra@tudelft.nl>
To: guile-commits@gnu.org
Subject: [Guile-commits] Failed with output: Hydra job gnu:guile-2-0:build.x86_64-darwin
Date: Wed, 12 Mar 2014 02:13:15 +0100
Message-ID: <20140312011318.B026F46017D@mx2.tudelft.nl>

Hi,

The status of Hydra job gnu:guile-2-0:build.x86_64-darwin has changed from "Success" to "Failed with output".  For details, see

  http://hydra.nixos.org/build/9432347

This is likely due to 184 commits by Bjørn Forsman <bjorn.forsman@gmail.com>, Cillian de Róiste <cillian.deroiste@gmail.com>, Domen Kozar <domen@dev.si>, Domen Kožar <domen@dev.si>, Eelco Dolstra <eelco.dolstra@logicblox.com>, Evgeny Egorochkin <phreedom@yandex.ru>, Jaka Hudoklin <jakahudoklin@gmail.com>, James Cook <james.cook@utoronto.ca>, José Romildo Malaquias <malaquias@gmail.com>, Ludovic Courtès <ludo@gnu.org>, Matej Cotman <cotman.matej@gmail.com>, Mathijs Kwik <mathijs@bluescreen303.nl>, Michael Raskin <7c6f434c@mail.ru>, Moritz Ulrich <moritz@tarn-vedra.de>, Peter Simons <simons@cryp.to>, Ricardo M. Correia <rcorreia@wizy.org>, Rickard Nilsson <rickynils@gmail.com>, Vladimir Still <vl.still@gmail.com> or Vladimír Čunát <vcunat@gmail.com>.

Go forth and fix it.

Regards,

The Hydra build daemon.

Re: [Hydra Build Daemon] [Guile-commits] Failed with output: Hydra job gnu:guile-2-0:build.x86_64-darwin

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> The Darwin build was broken by 8f7887d61604073528544ccb09849ca0e2f4df78
> "Provide glthread/lock.h implementation in terms of Guile threads".
>
> I guess that we'll need to add some of the AM_CPPFLAGS from
> libguile/Makefile.am to lib/Makefile.am.
>
> We'll need to make sure not only that <glthread/lock.h> finds
> <libguile/threads.h> from the source tree (not from previously-installed
> Guile headers),

Oops, thanks for the heads-up.  The problem manifests when $top_srcdir
!= $top_builddir, as is the case on Hydra.

> but also that all of the Guile headers included directly or indirectly
> from <libguile/threads.h> have access to the Gnulib headers.

I believe commit da7e43a fixes it.

> I confess to being a bit nervous about this circular dependency between
> Guile and Gnulib.

Yeah.

Another thing we could do is to AC_DEFINE([SCM_GNULIB_LOCK_PTHREAD])
when building with pthread support, and have glthread/lock.h not include
<libguile/threads.h> at all.

WDYT?

Ludo’.