unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: lloda <lloda@sarc.name>
To: Maxime Devos <maximedevos@telenet.be>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] New function array-mutable?
Date: Thu, 25 Nov 2021 19:56:49 +0100	[thread overview]
Message-ID: <367DEE5F-9FE4-457E-9B81-BB1605F1EDFF@sarc.name> (raw)
In-Reply-To: <53901e95268fe40d7bb426851af6e9e9354d2376.camel@telenet.be>



> On 25 Nov 2021, at 19:22, Maxime Devos <maximedevos@telenet.be> wrote:
> 
> lloda schreef op do 25-11-2021 om 17:40 [+0100]:
>> +Arrays with empty roots are not considered immutable because
>> +@code{array-set!} operations with valid indices won't fail (since
>> there
>> +are no valid indices).
>> +
>> +@example
>> +(array-mutable? #()) @result{} #t
>> +@end example
>> +@end deffn
> 
> By this logic, shouldn't empty subarrays (*) with a possibly mutable
> and non-empty root be considered mutable as well?
> 
> (*) called ‘shared arrays’ in the manual
> 
> Greetings,
> Maxime

That would make sense, I think.

The test in the patch is the same one that is used to validate array_handle_xxx_writable_elements(), which looks only at the root and not at the array dimensions. Those two tests should be the same, so I'll have to change the test in array_handle_xxx_writable_elements().

Thanks

	Daniel





  reply	other threads:[~2021-11-25 18:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 16:40 [PATCH] New function array-mutable? lloda
2021-11-25 18:19 ` Maxime Devos
2021-11-25 19:10   ` lloda
     [not found]   ` <97DC61EC-3DD4-444B-98DB-AB9A823EA1F3@sarc.name>
2021-12-09 20:34     ` Maxime Devos
2021-11-25 18:22 ` Maxime Devos
2021-11-25 18:56   ` lloda [this message]
2021-11-27  8:42     ` lloda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=367DEE5F-9FE4-457E-9B81-BB1605F1EDFF@sarc.name \
    --to=lloda@sarc.name \
    --cc=guile-devel@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).