unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: lloda <lloda@sarc.name>
To: Maxime Devos <maximedevos@telenet.be>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] New function array-mutable?
Date: Thu, 25 Nov 2021 20:10:49 +0100	[thread overview]
Message-ID: <BC815C90-967D-4EFC-8A66-AC438343091F@sarc.name> (raw)
In-Reply-To: <c247ec639f744ddc1c215bd2370f13c68b4eca5b.camel@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]



> On 25 Nov 2021, at 19:19, Maxime Devos <maximedevos@telenet.be> wrote:
> 
> lloda schreef op do 25-11-2021 om 17:40 [+0100]:
>> [...]
> 
> Suggestion: add a few tests to test-suite/tests/arrays.test:
> 
> (pass-if-equal "new"
>  #t
>  (array-mutable? (make-array #f '(1 2) '(3 4))))
> 
> (pass-if-equal "empty (two-dimensional)"
>  #t
>  (array-mutable? (array-copy #1())))
> 
> (pass-if-equal "empty (two-dimensional)"
>  #t
>  (array-mutable? (array-copy #2(() ()))))
> 
> (pass-if-equal "immutable copy"
>  #f
>  (array-mutable? (immutable-array-copy #2((h) (h)))))
> 
> This requires a currently non-existent procedure ‘make-immutable-
> array’, copying an array into a new immutable array.
> 
> Greetings,
> Maxime

I think literal arrays are always immutable, and one could base the test on that.

Is such a function useful in some other context? If one has an array which is already immutable, it can be referenced freely and copying it seems unnecessary. If one has a mutable array, is there any reason why one would want to make an immutable copy?

regards

	Daniel


[-- Attachment #2: Type: text/html, Size: 3221 bytes --]

  reply	other threads:[~2021-11-25 19:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 16:40 [PATCH] New function array-mutable? lloda
2021-11-25 18:19 ` Maxime Devos
2021-11-25 19:10   ` lloda [this message]
     [not found]   ` <97DC61EC-3DD4-444B-98DB-AB9A823EA1F3@sarc.name>
2021-12-09 20:34     ` Maxime Devos
2021-11-25 18:22 ` Maxime Devos
2021-11-25 18:56   ` lloda
2021-11-27  8:42     ` lloda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BC815C90-967D-4EFC-8A66-AC438343091F@sarc.name \
    --to=lloda@sarc.name \
    --cc=guile-devel@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).