From: "Chris K. Jester-Young" <cky944@gmail.com>
To: guile-devel@gnu.org
Subject: Re: [PATCH] Add procedures to convert alists into hash tables
Date: Mon, 28 Oct 2013 08:17:57 -0400 [thread overview]
Message-ID: <20131028121757.GA11365@lotus.destinee.acro.gen.nz> (raw)
In-Reply-To: <5265EB0D.2050802@worcester.edu>
On Mon, Oct 21, 2013 at 11:03:41PM -0400, David Thompson wrote:
> Thank you for taking the time to give some really useful feedback,
> Mark Weaver. I appreciate it.
He always writes really detailed reviews, which I highly appreciate. :-)
On which note, I have an additional nitpick:
> * libguile/hashtab.h (scm_alist_to_hash_table, scm_alist_to_hashq_table,
> scm_alist_to_hashv_table, scm_alist_to_hashx_table): New prototypes.
>
> * libguile/hashtab.c (scm_alist_to_hash_table, scm_alist_to_hashq_table,
> scm_alist_to_hashv_table, scm_alist_to_hashx_table): New procedures.
> (SCM_ALIST_TO_HASH_TABLE): New macro.
In the GNU ChangeLog format, when you have a list of functions that
exceed one line, you should close parens at the end of each line and
reopen on the next. Thus:
* libguile/hahstab.c (scm_alist_to_hash_table, scm_alist_to_hashq_table)
(scm_alist_to_hashv_table, scm_alist_to_hashx_table): New procedures.
> Good to know. Still trying to get used to this commit format.
If you're talking about the commit message format, we largely follow the
GNU ChangeLog format, which is described here:
http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html
Cheers,
Chris.
next prev parent reply other threads:[~2013-10-28 12:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 14:14 [PATCH] Add procedures to convert alists into hash tables David Thompson
2013-10-20 14:28 ` David Thompson
2013-10-21 17:00 ` Mark H Weaver
2013-10-22 3:03 ` David Thompson
2013-10-28 12:17 ` Chris K. Jester-Young [this message]
2013-10-28 23:51 ` David Thompson
2013-10-26 11:41 ` David Thompson
2013-10-29 12:38 ` Ludovic Courtès
2013-10-30 20:19 ` Thompson, David
2013-11-03 12:43 ` Thien-Thi Nguyen
2013-11-05 19:57 ` Mark H Weaver
2013-11-06 12:54 ` Ludovic Courtès
2013-11-06 13:14 ` Thompson, David
2013-11-18 1:50 ` David Thompson
2013-11-18 2:42 ` David Thompson
2013-11-18 3:22 ` Mark H Weaver
2013-11-18 20:32 ` Ludovic Courtès
2013-11-19 2:00 ` David Thompson
2013-11-19 4:06 ` Mark H Weaver
2013-11-19 13:14 ` Thompson, David
2014-03-24 21:06 ` Andy Wingo
2014-03-24 22:15 ` Ludovic Courtès
2014-03-24 22:26 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131028121757.GA11365@lotus.destinee.acro.gen.nz \
--to=cky944@gmail.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).