From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Chris K. Jester-Young" Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add procedures to convert alists into hash tables Date: Mon, 28 Oct 2013 08:17:57 -0400 Message-ID: <20131028121757.GA11365@lotus.destinee.acro.gen.nz> References: <5263E55A.6040307@worcester.edu> <5263E891.3030801@worcester.edu> <87r4beftk7.fsf@netris.org> <5265EB0D.2050802@worcester.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1382962712 25158 80.91.229.3 (28 Oct 2013 12:18:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Oct 2013 12:18:32 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Oct 28 13:18:37 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ValmG-0005Io-UE for guile-devel@m.gmane.org; Mon, 28 Oct 2013 13:18:37 +0100 Original-Received: from localhost ([::1]:41165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ValmG-0006pt-E1 for guile-devel@m.gmane.org; Mon, 28 Oct 2013 08:18:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Valm9-0006os-4l for guile-devel@gnu.org; Mon, 28 Oct 2013 08:18:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Valm2-00046K-R3 for guile-devel@gnu.org; Mon, 28 Oct 2013 08:18:29 -0400 Original-Received: from mail-qc0-x22a.google.com ([2607:f8b0:400d:c01::22a]:48241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Valm2-00045q-MX for guile-devel@gnu.org; Mon, 28 Oct 2013 08:18:22 -0400 Original-Received: by mail-qc0-f170.google.com with SMTP id n9so3758970qcw.29 for ; Mon, 28 Oct 2013 05:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=aX29JBBsy3U0BRn0nYBeOzG6+0DeWP886pMPNE3fnUk=; b=Lbmu+ViK1bJoc36I/JrxW3Js4KfjIu/5m1z3l8NSgKMIqbFzxyfWD6wGRqzBw1wLx/ ZUkP9RpilaFzlGAJm4Mw/FlrVLpsPf2okIoa6cwV9v4oeDJb+k3NmsrNIpWv1MfulKfn vnl6Qb/PLBdzHPM7b0K4r96IoLMZoFdM1b1wfg2tWhx0WuNA8mmogKtCZkhHN86G7I/0 Ij30ANIIFxM6wtUoDLNdQ2MExMiH6/2LN/Kc4r7Cu66af9wAWplypkRhz4ewRd2ICXnY bKCvK+/4xfZK2FCuKERRtujum5gKu4xNBrHYRBXiv+1g/tWGI2bPGOgIPkJ6IAoDQHjP cm5Q== X-Received: by 10.224.127.68 with SMTP id f4mr19173209qas.62.1382962701600; Mon, 28 Oct 2013 05:18:21 -0700 (PDT) Original-Received: from lotus.destinee.acro.gen.nz (cpe-107-015-120-110.nc.res.rr.com. [107.15.120.110]) by mx.google.com with ESMTPSA id h9sm52463360qaq.9.2013.10.28.05.18.20 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 28 Oct 2013 05:18:20 -0700 (PDT) Mail-Followup-To: guile-devel@gnu.org Content-Disposition: inline In-Reply-To: <5265EB0D.2050802@worcester.edu> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c01::22a X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16690 Archived-At: On Mon, Oct 21, 2013 at 11:03:41PM -0400, David Thompson wrote: > Thank you for taking the time to give some really useful feedback, > Mark Weaver. I appreciate it. He always writes really detailed reviews, which I highly appreciate. :-) On which note, I have an additional nitpick: > * libguile/hashtab.h (scm_alist_to_hash_table, scm_alist_to_hashq_table, > scm_alist_to_hashv_table, scm_alist_to_hashx_table): New prototypes. > > * libguile/hashtab.c (scm_alist_to_hash_table, scm_alist_to_hashq_table, > scm_alist_to_hashv_table, scm_alist_to_hashx_table): New procedures. > (SCM_ALIST_TO_HASH_TABLE): New macro. In the GNU ChangeLog format, when you have a list of functions that exceed one line, you should close parens at the end of each line and reopen on the next. Thus: * libguile/hahstab.c (scm_alist_to_hash_table, scm_alist_to_hashq_table) (scm_alist_to_hashv_table, scm_alist_to_hashx_table): New procedures. > Good to know. Still trying to get used to this commit format. If you're talking about the commit message format, we largely follow the GNU ChangeLog format, which is described here: http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html Cheers, Chris.