* Re: [PATCH] eval-string: Fix setting port column
[not found] <871q8d131g.fsf@asgard.mail-host-address-is-not-set>
@ 2024-03-20 20:12 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-05-06 9:38 ` bug#69921: " Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library @ 2024-03-20 20:12 UTC (permalink / raw)
To: Nikita Domnitskii, guile-devel; +Cc: bug-guile
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
> ---
> module/ice-9/eval-string.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f17777..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
> (if line
> (set-port-line! port line))
> (if column
> - (set-port-column! port line))
> + (set-port-column! port column))
>
> (if (or compile? (not (language-evaluator lang)))
> ((load-thunk-from-memory
>
>
LGTM (wrong since 2011, it seems), but needs somebody with commit
access to push.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#69921: [PATCH] eval-string: Fix setting port column
2024-03-20 20:12 ` [PATCH] eval-string: Fix setting port column Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
@ 2024-05-06 9:38 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2024-05-06 9:38 UTC (permalink / raw)
To: Jonas Hahnfeld; +Cc: 69921-done, Nikita Domnitskii, guile-devel
Jonas Hahnfeld <hahnjo@hahnjo.de> skribis:
> On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
>> ---
>> module/ice-9/eval-string.scm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
>> index ea0f17777..9cac03632 100644
>> --- a/module/ice-9/eval-string.scm
>> +++ b/module/ice-9/eval-string.scm
>> @@ -81,7 +81,7 @@
>> (if line
>> (set-port-line! port line))
>> (if column
>> - (set-port-column! port line))
>> + (set-port-column! port column))
>>
>> (if (or compile? (not (language-evaluator lang)))
>> ((load-thunk-from-memory
>>
>>
>
> LGTM (wrong since 2011, it seems), but needs somebody with commit
> access to push.
This was pushed as 025bb024ae4b586dc721e3d2e3471fbea5f8cc81.
Closing!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-06 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <871q8d131g.fsf@asgard.mail-host-address-is-not-set>
2024-03-20 20:12 ` [PATCH] eval-string: Fix setting port column Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2024-05-06 9:38 ` bug#69921: " Ludovic Courtès
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).