unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#30832: Please add support for new architecture "riscv64" (RISC-V 64 bits little-endian)
@ 2018-03-15 23:25 Manuel A. Fernandez Montecelo
  2018-03-16  4:21 ` Mark H Weaver
  0 siblings, 1 reply; 3+ messages in thread
From: Manuel A. Fernandez Montecelo @ 2018-03-15 23:25 UTC (permalink / raw)
  To: 30832

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

Hello,

Please add support for this architecture, simple patch attached (based
on guile-2.0, the most popular version in Debian).

The change is simply to add "riscv64" in the following location, the
arch name seems to be missing in:

  http://git.savannah.gnu.org/cgit/guile.git/tree/module/system/base/target.scm#n74

Since it ends in -64, the pointer size should be detected correctly in
the current code.

I compiled this and ran the test suite successfully:

Totals for this test run:
passes:                 40317
failures:               0
unexpected passes:      0
expected failures:      9
unresolved test cases:  571
untested test cases:    1
unsupported test cases: 10
errors:                 0

If there's anything missing, please let me know.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo@gmail.com>

[-- Attachment #2: riscv64.patch --]
[-- Type: text/x-patch, Size: 754 bytes --]

Index: guile-2.0-2.0.13+1/module/system/base/target.scm
===================================================================
--- guile-2.0-2.0.13+1.orig/module/system/base/target.scm
+++ guile-2.0-2.0.13+1/module/system/base/target.scm
@@ -65,7 +65,7 @@
       (cond ((string-match "^i[0-9]86$" cpu)
              (endianness little))
             ((member cpu '("x86_64" "ia64"
-                           "powerpcle" "powerpc64le" "mipsel" "mips64el" "nios2" "sh4" "alpha"))
+                           "powerpcle" "powerpc64le" "mipsel" "mips64el" "nios2" "sh4" "alpha" "riscv64"))
              (endianness little))
             ((member cpu '("sparc" "sparc64" "powerpc" "powerpc64" "spu"
                            "mips" "mips64" "m68k" "s390x"))

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#30832: Please add support for new architecture "riscv64" (RISC-V 64 bits little-endian)
  2018-03-15 23:25 bug#30832: Please add support for new architecture "riscv64" (RISC-V 64 bits little-endian) Manuel A. Fernandez Montecelo
@ 2018-03-16  4:21 ` Mark H Weaver
  2018-03-16 10:07   ` Manuel A. Fernandez Montecelo
  0 siblings, 1 reply; 3+ messages in thread
From: Mark H Weaver @ 2018-03-16  4:21 UTC (permalink / raw)
  To: Manuel A. Fernandez Montecelo; +Cc: 30832-done

"Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com> writes:
> Please add support for this architecture, simple patch attached (based
> on guile-2.0, the most popular version in Debian).

This should be fixed now, using a patch provided earlier by Shea Levy
which also covers riscv32.  See commit
08bb4628369cf3efe7c96a32919705c41a9ed9e9 on the stable-2.2 branch and
d6e669b8cb26f870ea6611a54788b75fbad67bbe on the stable-2.0 branch.

I'm closing this bug now, but please reopen if there are still issues.

     Thanks!
       Mark





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#30832: Please add support for new architecture "riscv64" (RISC-V 64 bits little-endian)
  2018-03-16  4:21 ` Mark H Weaver
@ 2018-03-16 10:07   ` Manuel A. Fernandez Montecelo
  0 siblings, 0 replies; 3+ messages in thread
From: Manuel A. Fernandez Montecelo @ 2018-03-16 10:07 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: 30832

2018-03-16 5:21 GMT+01:00 Mark H Weaver <mhw@netris.org>:
> "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com> writes:
>> Please add support for this architecture, simple patch attached (based
>> on guile-2.0, the most popular version in Debian).
>
> This should be fixed now, using a patch provided earlier by Shea Levy
> which also covers riscv32.  See commit
> 08bb4628369cf3efe7c96a32919705c41a9ed9e9 on the stable-2.2 branch and
> d6e669b8cb26f870ea6611a54788b75fbad67bbe on the stable-2.0 branch.
>
> I'm closing this bug now, but please reopen if there are still issues.

Ah, it's fine then.  I assumed that addition of new features started
in master and then some changes flowed down to stable branches when
needed.

Thanks!

-- 
Manuel A. Fernandez Montecelo <manuel.montezelo@gmail.com>





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-16 10:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15 23:25 bug#30832: Please add support for new architecture "riscv64" (RISC-V 64 bits little-endian) Manuel A. Fernandez Montecelo
2018-03-16  4:21 ` Mark H Weaver
2018-03-16 10:07   ` Manuel A. Fernandez Montecelo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).