bug#33652: let/ec bug

bug#33652: let/ec bug

[Stefan Israelsson Tampe]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

The following code does not compile on guile-2.9:

--------------------------------------------
(define-module (r)
  #:use-module (ice-9 control)
  #:export ())

(define ramanujan
  (lambda ()
  (let/ec break-ret
    (let lp ()
      (break-ret)
      (lp)))))
----------------------------------------------

The error report
;; WARNING: compilation of /home/stis/src/python-on-guile/modules/langua
ge/python/module/r.scm failed:
;;; not found 37

Regards
Stefan

[-- Attachment #2: Type: text/html, Size: 905 bytes --]

bug#33652: The optimization that fails

[Stefan Israelsson Tampe]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

(define f
  (compile
    '(lambda ()
       (let/ec b
         (let lp ()
            (b)
            (lp))))
      #:env (current-module) #:opts '(#:contify? #f)))

compiles so the issue is in the contify section of the optimizer.

[-- Attachment #2: Type: text/html, Size: 1049 bytes --]

bug#33652: Possible fix

[Stefan Israelsson Tampe]

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

When I apply this to head master:

diff --git a/module/language/cps/simplify.scm b/module/language/cps/simpl
ify.scm
index 311566043..b6fcffcd1 100644
--- a/module/language/cps/simplify.scm
+++ b/module/language/cps/simplify.scm
@@ -149,6 +149,9 @@
              (($ $kargs names syms ($ $branch kf kt src op param args))
               ($kargs names syms
                 ($branch (subst kf) (subst kt) src op param args)))
+              (($ $kargs names syms ($ $prompt k kh src escape? tag))
+               ($kargs names syms
+                 ($prompt (subst k) (subst kh) src escape? tag)))
              (($ $kargs names syms ($ $continue k src ($ $const val)))
               ,(match (intmap-ref conts k)
                  (($ $kargs (_)

Things compiles just fine

Regards
Stefan

[-- Attachment #2: Type: text/html, Size: 2007 bytes --]

bug#33652: close thanks

[Andy Wingo]

close
thanks

Fixed in master.  Thanks very much for the report and patch!